-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SD, USBDEVICE & LPTICKER support for VK_RZ_A1H board. #13639
Conversation
…CKER. Linker files synced with other Renesas boards.
@mbedNoobNinja, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Licensing update, the rest looks fine to me.
How was this tested?
* $Rev: $ | ||
* $Date:: $ | ||
* Description : SPI multi I/O bus controller register define header | ||
*******************************************************************************/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add
SPDX-License-Identifier
to new files, this is most probably one of the older licenses without it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is the same as the original: targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_RZ_A1H/device/inc/iobitmasks/spibsc_iobitmask.h.
If they don't know how it is licensed, I don't know either.
I have no idea how this license should look like.
Can you give some link to a valid files with license in question.
How was this tested?
What you mean?
The tests are done by mbed-cli 1.10.4 through the command mbed test
-t
compiler
-m
VK_RZ_A1H
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks , I did not know it is a copy of the file. It will be fixed separately.
Tests - I've noticed now there is a test log, reviewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests all passed,
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Summary of changes
Add
SD
,USBDEVICE
,LPTICKER
support.Some of the files are synced with the other Renesas boards.
VK_RZ_A1H
ones are a bit old, especially the linker script files!Impact of changes
SD
feature requires an external lib !Migration actions required
Projects using the
SD
feature, should includeSDHI
.Documentation
None
Pull request type
Test results
Tests.log
Reviewers