Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SD, USBDEVICE & LPTICKER support for VK_RZ_A1H board. #13639

Merged
merged 1 commit into from
Oct 13, 2020

Conversation

mbedNoobNinja
Copy link
Contributor

@mbedNoobNinja mbedNoobNinja commented Sep 18, 2020

Summary of changes

Add SD , USBDEVICE , LPTICKER support.
Some of the files are synced with the other Renesas boards. VK_RZ_A1H ones are a bit old, especially the linker script files!

Impact of changes

SD feature requires an external lib !

Migration actions required

Projects using the SD feature, should include SDHI.

Documentation

None


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Tests.log


Reviewers


…CKER.

Linker files synced with other Renesas boards.
@ciarmcom ciarmcom requested a review from a team September 18, 2020 16:30
@ciarmcom
Copy link
Member

@mbedNoobNinja, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Licensing update, the rest looks fine to me.

How was this tested?

* $Rev: $
* $Date:: $
* Description : SPI multi I/O bus controller register define header
*******************************************************************************/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add

SPDX-License-Identifier

to new files, this is most probably one of the older licenses without it.

Copy link
Contributor Author

@mbedNoobNinja mbedNoobNinja Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is the same as the original: targets/TARGET_RENESAS/TARGET_RZ_A1XX/TARGET_RZ_A1H/device/inc/iobitmasks/spibsc_iobitmask.h.

If they don't know how it is licensed, I don't know either.
I have no idea how this license should look like.
Can you give some link to a valid files with license in question.

How was this tested?

What you mean?
The tests are done by mbed-cli 1.10.4 through the command mbed test -t compiler -m VK_RZ_A1H

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks , I did not know it is a copy of the file. It will be fixed separately.

Tests - I've noticed now there is a test log, reviewing

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all passed,

@mergify mergify bot added needs: CI and removed needs: work labels Sep 21, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants