Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host privacy fixes #13670

Merged
merged 2 commits into from
Sep 28, 2020
Merged

Host privacy fixes #13670

merged 2 commits into from
Sep 28, 2020

Conversation

pan-
Copy link
Member

@pan- pan- commented Sep 25, 2020

Summary of changes

Last fixes for BLE privacy:

  • Peripheral policy applied to extended connection
  • Workaround cordio limitation which doesn't acknowledge the local address from advertising set.

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@pan-
BLE: Add workaround for cordio use of global random address
f56126d 
In Cordio, the global random address is used when the local device is connected instead of the advertising set one.
This can cause pairing to fail if the advertising set address and the global random address are different.
This workaround forces the global random address to be set when advertising is started and extended advertising is present.
@pan-
BLE: Factorize peripheral privacy applied when connected
567720c
@ciarmcom
Copy link
Member

@pan-, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team September 25, 2020 16:30
@paul-szczepanek-arm
Copy link
Member

@pan- pls merge

@pan- pan- merged commit 1b99763 into ARMmbed:feature-ble-host-privacy Sep 28, 2020
@pan- pan- mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-szczepanek-arm paul-szczepanek-arm paul-szczepanek-arm approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pan- @ciarmcom @paul-szczepanek-arm @adbridge