Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbed-os-5.15: Enable Nanostack DNS cache usage #13735

Merged

Conversation

artokin
Copy link
Contributor

@artokin artokin commented Oct 8, 2020

Summary of changes

Enable usage of Nanostack DNS cache. The cache may contain DNS server address and DNS query results.

Inherit methods gethostbyname, gethostbyname_async and get_dns_server to Nanostack class.
Methods will try to find DNS server address or DNS query results from Nanostack DNS cache.

These same changes are available in:

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom requested a review from a team October 8, 2020 07:00
@ciarmcom
Copy link
Member

ciarmcom commented Oct 8, 2020

@artokin, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

mikter
mikter previously approved these changes Oct 8, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Oct 8, 2020
@andypowers andypowers self-requested a review October 12, 2020 15:25
andypowers
andypowers previously approved these changes Oct 12, 2020
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@0xc0170 0xc0170 changed the title [mbed-os-5.15] Enable Nanostack DNS cache usage mbed-os-5.15: Enable Nanostack DNS cache usage Oct 13, 2020
@mergify mergify bot added needs: work and removed needs: CI labels Oct 13, 2020
@mergify mergify bot dismissed stale reviews from mikter, andypowers, and 0xc0170 October 13, 2020 11:34

Pull request has been modified.

@mbed-ci
Copy link

mbed-ci commented Oct 13, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest-lts

@mergify
Copy link

mergify bot commented Oct 13, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Arto Kinnunen added 5 commits October 14, 2020 09:08
Inherit methods gethostbyname, gethostbyname_async and get_dns_server
to Nanostack class. Methods will try to find DNS server address
or DNS query results from Nanostack DNS cache.
-Check address version NSAPI_UNSPEC
-Disable traces
-More specific interface ID parsing
-Harmonize return values
Add set_dns_query_result to WisunBorderRouter.
@artokin artokin force-pushed the enable_nanostack_dns_cache_mbed_os_5_15 branch from db3bd50 to 16d3dd4 Compare October 14, 2020 06:13
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2020

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Oct 21, 2020
@mbed-ci
Copy link

mbed-ci commented Oct 21, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test-lts

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 2c2b134 into ARMmbed:mbed-os-5.15 Oct 29, 2020
@mergify mergify bot removed the ready for merge label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants