Fix compilation warnings #13894
Merged
Fix compilation warnings #13894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@noonfom, thank you for your changes. |
|
@noonfom Please look at travis failures, look related |
| @@ -102,10 +102,13 @@ typedef struct secure_session { | |||
| } secure_session_t; | |||
|
|
|||
| static NS_LIST_DEFINE(secure_session_list, secure_session_t, link); | |||
|
|
|||
| #if COAP_SECURITY_AVAILABLE | |||
There was a problem hiding this comment.
Suggested change
| #if COAP_SECURITY_AVAILABLE | |
| #ifdef COAP_SECURITY_AVAILABLE |
and others
| @@ -885,7 +885,8 @@ void connection_handler_close_secure_connection(coap_conn_handler_t *handler, ui | |||
| if (handler->socket && handler->socket->is_secure) { | |||
| secure_session_t *session = secure_session_find(handler->socket, destination_addr_ptr, port); | |||
| if (session) { | |||
| #if COAP_SECURITY_AVAILABLE | |||
| #ifdef COAP_SECURITY_AVAILABLE | |||
| #ifdef COAP_SECURITY_AVAILABLE | |||
|
Thanks for the changes. Is the coap-service compiled also with COAP_SECURITY_AVAILABLE disabled? When we are making the next update, we will first merge these changes back to the original master repository. Then changes will not be lost. |
noonfom
force-pushed
the
fix_compilation_warnings
branch
from
70042b6
to
3e6cf78
Compare
paul-szczepanek-arm
approved these changes
Nov 11, 2020
Seems that way, otherwise CI wouldn't have failed when the #ifdef was mistakenly an #if and the define was missing. |
0xc0170
approved these changes
Nov 11, 2020
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.5.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Recently, a user found that compiling Mbed OS with the GCC_ARM toolchain produces several warnings that could affect program reliability (#13604). It is not possible to fix all the warnings since there are a lot of 3rd party components in the tree. However, simple solutions exist for a some of the warnings. A few are given in Mbed-TLS/mbedtls#3867; others are supplied here.
compout.txt gives the compiler output after making the changes.
mbed compile -c -m NUCLEO_F446RE -t GCC_ARM &> ../compout.txtcompout.txt
warning.txt gives the remaining warnings.
cat compout.txt | grep "Warning" > warning.txtwarning.txt
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@pan-
@paul-szczepanek-arm