Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stm32: delete objects.h #13973

Merged

Conversation

ladislas
Copy link
Contributor

@ladislas ladislas commented Nov 26, 2020

Summary of changes

When using cmake with DISCO_F769NI, compilation fails saying that common_objects.h is missing.

I traced the issue back to the presence of this file:

https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/TARGET_STM32F7/TARGET_STM32F769xI/objects.h

Removing the file solves the issue.

Impact of changes

Fixes cmake with this target

Migration actions required

n/a

Documentation

n/a


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 @hugueskamba @rajkan01 @jeromecoutant


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 26, 2020
@ciarmcom
Copy link
Member

@ladislas, thank you for your changes.
@hugueskamba @0xc0170 @rajkan01 @jeromecoutant @ARMmbed/team-st-mcd @ARMmbed/mbed-os-maintainers please review.

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK... Issue was introduced during #12860
Could you also remove 2 other files ? :-)
targets/TARGET_STM/TARGET_STM32F7/TARGET_STM32F746xG/objects.h
targets/TARGET_STM/TARGET_STM32F7/TARGET_STM32F756xG/objects.h

@ladislas ladislas force-pushed the ladislas-stm32f7-remove-objects_dot_h branch from b9e9509 to eba8df7 Compare November 27, 2020 08:24
@ladislas
Copy link
Contributor Author

ladislas commented Nov 27, 2020

@jeromecoutant ✅ and force pushed!

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 27, 2020

Thanks @ladislas

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 27, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: review labels Nov 27, 2020
@0xc0170 0xc0170 changed the title Delete objects.h stm32: delete objects.h Nov 27, 2020
@mbed-ci
Copy link

mbed-ci commented Nov 27, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 1d0e9b1 into ARMmbed:master Nov 27, 2020
@mergify mergify bot removed the ready for merge label Nov 27, 2020
@ladislas ladislas deleted the ladislas-stm32f7-remove-objects_dot_h branch November 27, 2020 10:32
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants