CMake: add Samsungs, Analog devices and WICED targets #14024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add CMakeLists.txt file * Update the list of supported target
TOOLCHAIN_ARM_STD is specific to Mbed OS and is not generated if Mbed CLI is not used.
Add configuration files for targets and individual MCUs. Add include paths and sources to mbed-core link library and specify linker and startup scripts.
Change interpreter program from armcc to armclang. Pass it different optional arguments: specify the target compiler and core core type.
…mba/mbed-os into hugueskamba-hk_cmake_wiced_suppport
…/mbed-os into dev_cmake_targets
…d-os into dev_cmake_targets
0xc0170
force-pushed
the
dev_cmake_targets
branch
from
2150a8c
to
e7315e8
Compare
|
CI started |
This was referenced Dec 10, 2020
ciarmcom
added
the
release-type: patch
|
@0xc0170, thank you for your changes. |
harmut01
reviewed
Dec 10, 2020
Comment on lines
27
to
32
| # dcxo_update.cpp | ||
| # mbed_main_init.cpp | ||
| # modem/modem_io_device.cpp | ||
| # modem/modem_link_device_shmem.cpp | ||
| # modem/s5js100_mbox_ipc.cpp | ||
| # modem/shmem_save.cpp |
There was a problem hiding this comment.
@0xc0170 are we okay leaving a TODO comment in the configuration file?
There was a problem hiding this comment.
I've missed this. It would be the best to remove (I'll do it now) and create an issue for this to be fixed.
harmut01
previously approved these changes
Dec 10, 2020
tracked here ARMmbed#14025
mergify
bot
dismissed
harmut01’s stale review
Pull request has been modified.
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Jenkins CI Test : ❌ FAILEDBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This contains:
#13972
#13977
#14019
all 3 are dependent on each other as they touch the same files so creating conflicts. I resolved them and providing this a bulk PR to get in together. They were already reviewed and approved.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers