Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SD component and Update SD card SPI interface for Maxim's MAX32630FTHR #14036

Merged

Conversation

ahmetalincak
Copy link

Summary of changes

To support MAX32630FTHR SD card interface implicitly,
target and SD component configurations updated.

Impact of changes

SD component is included implicitly in mbed-os for MAX32630FTHR.

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


To support MAX32630FTHR SD card interface implicitly,
target and SD component configurations updated.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 11, 2020
@ciarmcom ciarmcom requested review from a team December 11, 2020 22:30
@ciarmcom
Copy link
Member

@ahmetalincak, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from storage's perspective.
@ARMmbed/team-maximintegrated Would you please review the target update?

@ahmetalincak
Copy link
Author

@ARMmbed/mbed-os-maintainers Can you please review this? Approved by Maxim and ARM mbed-os-core.

@mergify mergify bot added needs: CI and removed needs: review labels Dec 18, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 18, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit 9e5e245 into ARMmbed:master Dec 18, 2020
@mergify mergify bot removed the ready for merge label Dec 18, 2020
@ahmetalincak ahmetalincak deleted the maxim-max32630fthr-SD-configuration branch December 18, 2020 15:13
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants