Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Add support for all Ambiq Micro Mbed targets #14042

Merged
merged 4 commits into from
Dec 17, 2020

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Dec 14, 2020

Summary of changes

  • Add CMakeLists.txt files to add support for all Ambiq Micro targets.
  • Fix Apollo3 BLE driver CMake support
  • Fix boot stack size definition in ARM linker file

GCC_ARM toolchain support depended on #13997 which was successfully resolved.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 14, 2020
@ciarmcom ciarmcom requested review from a team December 14, 2020 17:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-connectivity @ARMmbed/team-sparkfun @ARMmbed/mbed-os-maintainers please review.

harmut01
harmut01 previously approved these changes Dec 15, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Dec 15, 2020
0xc0170
0xc0170 previously approved these changes Dec 16, 2020
@mergify
Copy link

mergify bot commented Dec 17, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

Workaround a bug where the boot stack size configuration option is not
passed on to armlink, the Arm Compiler's linker. Prefer
MBED_CONF_TARGET_BOOT_STACK_SIZE if present, as this is what the
configuration system should provide. Fall back to MBED_BOOT_STACK_SIZE
if MBED_CONF_TARGET_BOOT_STACK_SIZE is not defined, as in the case of
buggy tools. If both MBED_CONF_TARGET_BOOT_STACK_SIZE and
MBED_BOOT_STACK_SIZE are not defined, then we fall back to a hard-coded
value provided by the linkerscript. See
ARMmbed#13474 for more information.
@mergify mergify bot dismissed stale reviews from harmut01 and 0xc0170 December 17, 2020 11:14

Pull request has been modified.

@hugueskamba
Copy link
Collaborator Author

This force-push rebased from master to solve the merge conflict.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 17, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 24501df into ARMmbed:master Dec 17, 2020
@mergify mergify bot removed the ready for merge label Dec 17, 2020
@hugueskamba hugueskamba deleted the hk_cmake_ambiq_micro_support branch December 17, 2020 15:15
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants