Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bare-metal support for MAXIM targets #14080

Merged
merged 1 commit into from Jan 20, 2021
Merged

Add bare-metal support for MAXIM targets #14080

merged 1 commit into from Jan 20, 2021

Conversation

ahmetalincak
Copy link

Summary of changes

Add bare-metal support for MAX32630FTHR board

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 21, 2020
@ciarmcom ciarmcom requested a review from a team December 21, 2020 16:00
@ciarmcom
Copy link
Member

@ahmetalincak, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ahmetalincak ahmetalincak changed the title Add bare-metal support for MAX32630FTHR board Add bare-metal support for MAXIM targets Dec 28, 2020
hugueskamba
hugueskamba reviewed Dec 31, 2020
View reviewed changes
targets/targets.json Outdated Show resolved Hide resolved
targets/targets.json Outdated Show resolved Hide resolved
targets/targets.json Outdated Show resolved Hide resolved
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2021

Please also rebase to the latest master to fix travis failure.

@ahmetalincak ahmetalincak force-pushed the max32630fthr-bare-metal-support branch from d4b7ab7 to 819d3fc Compare January 7, 2021 06:14
@ahmetalincak
Copy link
Author

Please also rebase to the latest master to fix travis failure.

Rebased. @0xc0170

@adbridge
Copy link
Contributor

adbridge commented Jan 7, 2021

@0xc0170 @hugueskamba please re-review, I'll start the CI in the meantime

@mbed-ci
Copy link

mbed-ci commented Jan 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@ahmetalincak
Copy link
Author

@0xc0170 Please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2021

CI restarted

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

CI restarted

@mergify mergify bot added needs: work and removed needs: CI labels Jan 19, 2021
@mbed-ci
Copy link

mbed-ci commented Jan 19, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ❌
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-example-ARM ❌
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

I am investigating the failures (not related to this PR).

@ahmetalincak
Copy link
Author

@0xc0170 Can't see why the checks failed.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

It looks like this is somewhere in our example or CI, we are checking. Some other Prs are also affected, will report back.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 20, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 4 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 080ea9f into ARMmbed:master Jan 20, 2021
@mergify mergify bot removed the ready for merge label Jan 20, 2021
@ahmetalincak ahmetalincak deleted the max32630fthr-bare-metal-support branch January 21, 2021 05:39
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
@ahmetalincak ahmetalincak mentioned this pull request Mar 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@hugueskamba hugueskamba hugueskamba approved these changes

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ahmetalincak @ciarmcom @0xc0170 @adbridge @mbed-ci @hugueskamba @mbedmain