Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Add support for LoRaWAN Greentea tests #14098

Merged
merged 2 commits into from
Jan 20, 2021
Merged

CMake: Add support for LoRaWAN Greentea tests #14098

merged 2 commits into from
Jan 20, 2021

Conversation

hugueskamba
Copy link
Collaborator

@hugueskamba hugueskamba commented Dec 29, 2020 •
edited
Loading

Summary of changes

The LoRaWAN Greentea tests can now be built with CMake

Depends on #14072

Impact of changes

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@hugueskamba hugueskamba mentioned this pull request Dec 29, 2020
Merged
@mergify mergify bot added the needs: work label Dec 29, 2020
@adbridge adbridge added the release-type: patch Indentifies a PR as containing just a patch label Jan 6, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

this needs a rebase to resolve travis python issue

@hugueskamba
Copy link
Collaborator Author

this needs a rebase to resolve travis python issue

Done.

@mergify mergify bot added needs: work and removed needs: CI labels Jan 14, 2021
@mergify
Copy link

mergify bot commented Jan 14, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@hugueskamba
CMake: Add MbedTLS dependency to LoRaWAN library
5616537 
This way applications that need LoRaWAN do need to also add MbedTLS
@hugueskamba
CMake: Add support for LoRaWAN Greentea test
9985392 
The LoRaWAN Greentea test can now be built with CMake.
@hugueskamba
Copy link
Collaborator Author

This force-push fixes the merge conflict.

@mergify mergify bot added needs: CI and removed needs: review labels Jan 18, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2021

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

CI restarted

@mergify mergify bot added the needs: work label Jan 19, 2021
@mergify mergify bot removed the needs: CI label Jan 19, 2021
@mbed-ci
Copy link

mbed-ci commented Jan 19, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ❌
jenkins-ci/mbed-os-ci_build-example-ARM ❌
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

Internal error, we will restart CI once it's ready.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 19, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Jan 20, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 8145477 into ARMmbed:master Jan 20, 2021
@mergify mergify bot removed the ready for merge label Jan 20, 2021
@hugueskamba hugueskamba deleted the hk_cmake_greentea_lorawan branch January 20, 2021 15:20
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@pan- pan- Awaiting requested review from pan-

@kivaisan kivaisan Awaiting requested review from kivaisan

@paul-szczepanek-arm paul-szczepanek-arm Awaiting requested review from paul-szczepanek-arm

@rajkan01 rajkan01 Awaiting requested review from rajkan01

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hugueskamba @0xc0170 @mbed-ci @adbridge @mbedmain