Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Remove make.py test for events and littlefs #14143

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

Fixes #14139

The removed tests were building applications from the content of their
respective README files. The events test was building with the full profile twice.
The first time with the repository as is; and the second time after deleting
some directories (to simulate the baremetal profile).
The littlefs test was building once with the full profile.

Testing make.py is no longer required as it is no longer supported.
There is already test coverage for APIs in the removed tests.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


The removed tests were building applications from the content of their
respective README files. The events test was building with the full profile twice.
The first time with the repository as is; and the second time after deleting
some directories (to simulate the baremetal profile).
The littlefs test was building once with the full profile.

Testing make.py is no longer required as it is no longer supported.
There is already test coverage for APIs in the removed tests.
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 12, 2021
@ciarmcom ciarmcom requested a review from a team January 12, 2021 18:30
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also remove littlefs - a question is why littlefs is part of travis and not other components as well? Lets check the tests and the CI and remove it

@hugueskamba
Copy link
Collaborator Author

hugueskamba commented Jan 13, 2021

should we also remove littlefs - a question is why littlefs is part of travis and not other components as well? Lets check the tests and the CI and remove it

That IMO is another conversation to have independently of this PR.

@0xc0170 0xc0170 merged commit dde7b22 into ARMmbed:master Jan 18, 2021
@mergify mergify bot removed the ready for merge label Jan 18, 2021
@hugueskamba hugueskamba deleted the hk_ci_remove_extended_tests branch January 18, 2021 11:33
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

travis: remove make.py tests (littlefs, events)
4 participants