Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: remove debug print #14298

Merged
merged 1 commit into from Feb 23, 2021
Merged

CMake: remove debug print #14298

merged 1 commit into from Feb 23, 2021

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Feb 17, 2021

Summary of changes

This was left in the tree unfortunately. me doing 馃檮 when I realized I know where this comes from....

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 17, 2021
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team February 17, 2021 17:00
@ciarmcom ciarmcom added needs: review stale Stale Pull Request labels Feb 17, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 22, 2021

CI started

@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @hugueskamba, @rajkan01, @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions.

@mbed-ci
Copy link

mbed-ci commented Feb 22, 2021

Jenkins CI Test : 鉁旓笍 SUCCESS

Build Number: 1 | 馃敀 Jenkins CI Job | 馃寪 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests 鉁旓笍
jenkins-ci/mbed-os-ci_build-greentea-ARM 鉁旓笍
jenkins-ci/mbed-os-ci_cmake-example-ARM 鉁旓笍
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM 鉁旓笍
jenkins-ci/mbed-os-ci_build-example-ARM 鉁旓笍
jenkins-ci/mbed-os-ci_build-cloud-example-ARM 鉁旓笍
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM 鉁旓笍
jenkins-ci/mbed-os-ci_build-example-GCC_ARM 鉁旓笍
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM 鉁旓笍
jenkins-ci/mbed-os-ci_cmake-example-test 鉁旓笍
jenkins-ci/mbed-os-ci_greentea-test 鉁旓笍

Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciarmcom ciarmcom removed the stale Stale Pull Request label Feb 23, 2021
@0xc0170 0xc0170 merged commit 14a5c79 into master Feb 23, 2021
@mergify mergify bot removed the ready for merge label Feb 23, 2021
@mbedmain mbedmain added release-version: 6.9.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Mar 15, 2021
@0xc0170 0xc0170 deleted the cmake-remove-debug-print branch October 5, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants