CMake: Pass application/test name to post build operation #14378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a target has a post binary hook, we should force regenerate the application binaries every time so that the hook is run on a raw binary rather than a previous build that already went through the post-build process once.
Pass the exact name to the post-build hook, when an application's or test's `CMakeLists.txt` calls `mbed_set_post_build()`. The interface is CMake's built-in mechanism: * `set_target_properties()` to set a property, e.g. application name * `$<TARGET_PROPERTY:target,property>` to query a property at run time
hugueskamba
reviewed
Mar 4, 2021
ciarmcom
added
the
release-type: patch
ciarmcom
requested review from
0xc0170,
hugueskamba,
rajkan01,
rwalton-arm and
a team
|
@LDong-Arm, thank you for your changes. |
hugueskamba
reviewed
Mar 4, 2021
targets/TARGET_Cypress/scripts/mbed_set_post_build_cypress.cmake
Outdated
Show resolved
Hide resolved
This removes the need to use "glob" a file extension, and uses precise application names.
This removes the need to use "glob" a file extension, and uses precise application names.
LDong-Arm
force-pushed
the
post_build_rework
branch
from
703c859
to
8483411
Compare
hugueskamba
approved these changes
Mar 4, 2021
0xc0170
approved these changes
Mar 5, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.9.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Pass the exact application (main CMake target) name to the post-build hook, when an application's or test's
CMakeLists.txtcallsmbed_set_post_build(). The interface is CMake's built-in mechanism:set_target_properties()to set a property (e.g. application name) on the customer target$<TARGET_PROPERTY:target,property>to query the propertyThis removes the need to use "glob" to find binaries, which is less reliable. The PR refactors existing targets (Cypress, NXP) to use the new mechanism.
Additionally, this PR forces the regeneration of raw application binaries on rebuild, to avoid having the post build running again on an already treated binary from a previous build.
Impact of changes
Migration actions required
Documentation
None.
Pull request type
Test results
Manually tested mbed-os-example-blinky and Greentea test compilation on
CYTFM_064B0S2_4343W(Cypress) andARCH_PRO(NXP).Reviewers
@hugueskamba @0xc0170 @rajkan01 @rwalton-arm