Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature-wisun] Added API to reset MAC and Wi-SUN statistics. #14439

Merged
merged 2 commits into from Apr 13, 2021
Merged

[feature-wisun] Added API to reset MAC and Wi-SUN statistics. #14439

merged 2 commits into from Apr 13, 2021

Conversation

debdeep-arm
Copy link
Contributor

Summary of changes

Added API to reset MAC statistics and Wi-SUN statistics.

Impact of changes

Migration actions required

Documentation

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mikter @mikaleppanen @artokin

@ciarmcom ciarmcom requested review from artokin, mikaleppanen, mikter and a team March 17, 2021 17:00
@ciarmcom
Copy link
Member

@debdeep-arm, thank you for your changes.
@mikaleppanen @mikter @artokin @ARMmbed/mbed-os-maintainers please review.

@debdeep-arm
Copy link
Contributor Author

@mikter @artokin @mikaleppanen Please review once again.

@debdeep-arm debdeep-arm requested a review from mikter March 18, 2021 11:47
mikter
mikter previously approved these changes Mar 18, 2021
View reviewed changes
@mergify mergify bot dismissed mikter’s stale review March 19, 2021 07:27

Pull request has been modified.

@debdeep-arm debdeep-arm requested a review from mikter March 22, 2021 05:25
@debdeep-arm
Copy link
Contributor Author

Needs review.

mikter
mikter previously approved these changes Mar 22, 2021
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: work labels Mar 22, 2021
artokin
artokin previously approved these changes Mar 23, 2021
View reviewed changes
@adbridge
Copy link
Contributor

Ci started

@mergify mergify bot added needs: work and removed needs: CI labels Mar 25, 2021
@mbed-ci
Copy link

mbed-ci commented Mar 25, 2021

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_example-test-lts

@debdeep-arm
Copy link
Contributor Author

I could not understand what went wrong here.
@mikaleppanen could you please help ?

@mergify mergify bot dismissed stale reviews from mikter and artokin April 6, 2021 12:36

Pull request has been modified.

@debdeep-arm
Copy link
Contributor Author

@0xc0170 Is it possible to run the CI here ?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2021

Marked as for CI, will run today

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 8, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 8, 2021

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 2
Build artifacts

@artokin artokin merged commit 72c3981 into ARMmbed:feature-wisun Apr 13, 2021
@mergify mergify bot removed the ready for merge label Apr 13, 2021
@artokin
Copy link
Contributor

artokin commented Apr 13, 2021

@debdeep-arm , do you have the PR for the other branches?

@debdeep-arm
Copy link
Contributor Author

@debdeep-arm , do you have the PR for the other branches?

I have not created any other PR.
Should I create PR against master and mbed-os-5.15 branch ?

@artokin
Copy link
Contributor

artokin commented Apr 13, 2021

Yes please

This was referenced Apr 20, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikter mikter mikter left review comments

@artokin artokin artokin left review comments

@mikaleppanen mikaleppanen Awaiting requested review from mikaleppanen

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@debdeep-arm @ciarmcom @adbridge @mbed-ci @0xc0170 @artokin @mikter