Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32 : enable PinMap_GPIO table #14451

Merged
merged 3 commits into from
Apr 28, 2021
Merged

STM32 : enable PinMap_GPIO table #14451

merged 3 commits into from
Apr 28, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Goal is:

Proposition if first implemented with:

  • DISCO_L475VG_IOT01A
  • NUCLEO_WB55RG

Updates done with
https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_STM/tools/STM32_gen_PeripheralPins.py
script

FPGA tests verified OK

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

FPGA tests verified.

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 19, 2021
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team March 19, 2021 14:30
@mergify
Copy link

mergify bot commented Mar 22, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 22, 2021

@jeromecoutant We merged pinmap consolidation, it created the conflicts seen here now.

@jeromecoutant
Copy link
Collaborator Author

@jeromecoutant We merged pinmap consolidation, it created the conflicts seen here now.

Done

@jamesbeyond

target platform_name test suite result elapsed_time (sec) copy_method
DISCO_L475VG_IOT01A-ARMC6 DISCO_L475VG_IOT01A hal-tests-tests-mbed_hal_fpga_ci_test_shield-analogin OK 19.59 default
DISCO_L475VG_IOT01A-ARMC6 DISCO_L475VG_IOT01A hal-tests-tests-mbed_hal_fpga_ci_test_shield-gpio OK 21.16 default
DISCO_L475VG_IOT01A-ARMC6 DISCO_L475VG_IOT01A hal-tests-tests-mbed_hal_fpga_ci_test_shield-gpio_irq OK 17.3 default
DISCO_L475VG_IOT01A-ARMC6 DISCO_L475VG_IOT01A hal-tests-tests-mbed_hal_fpga_ci_test_shield-i2c OK 19.78 default
DISCO_L475VG_IOT01A-ARMC6 DISCO_L475VG_IOT01A hal-tests-tests-mbed_hal_fpga_ci_test_shield-pwm OK 215.53 default
DISCO_L475VG_IOT01A-ARMC6 DISCO_L475VG_IOT01A hal-tests-tests-mbed_hal_fpga_ci_test_shield-spi OK 58.9 default
DISCO_L475VG_IOT01A-ARMC6 DISCO_L475VG_IOT01A hal-tests-tests-mbed_hal_fpga_ci_test_shield-uart OK 57.88 default
DISCO_L475VG_IOT01A-ARMC6 DISCO_L475VG_IOT01A hal-tests-tests-mbed_timing_fpga_ci_test_shield-watchdog OK 30.1 default
target platform_name test suite result elapsed_time (sec) copy_method
NUCLEO_WB55RG-ARMC6 NUCLEO_WB55RG hal-tests-tests-mbed_hal_fpga_ci_test_shield-analogin OK 19.06 default
NUCLEO_WB55RG-ARMC6 NUCLEO_WB55RG hal-tests-tests-mbed_hal_fpga_ci_test_shield-gpio OK 21.58 default
NUCLEO_WB55RG-ARMC6 NUCLEO_WB55RG hal-tests-tests-mbed_hal_fpga_ci_test_shield-gpio_irq OK 17.4 default
NUCLEO_WB55RG-ARMC6 NUCLEO_WB55RG hal-tests-tests-mbed_hal_fpga_ci_test_shield-i2c OK 20.72 default
NUCLEO_WB55RG-ARMC6 NUCLEO_WB55RG hal-tests-tests-mbed_hal_fpga_ci_test_shield-pwm OK 199.45 default
NUCLEO_WB55RG-ARMC6 NUCLEO_WB55RG hal-tests-tests-mbed_hal_fpga_ci_test_shield-spi OK 67.94 default
NUCLEO_WB55RG-ARMC6 NUCLEO_WB55RG hal-tests-tests-mbed_hal_fpga_ci_test_shield-uart OK 45.84 default
NUCLEO_WB55RG-ARMC6 NUCLEO_WB55RG hal-tests-tests-mbed_timing_fpga_ci_test_shield-watchdog OK 29.73 default

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2021

@jeromecoutant Please review Travis failure, one of the targets fail to pass pinvalidate.

@jeromecoutant
Copy link
Collaborator Author

Waiting for #14480

@mergify
Copy link

mergify bot commented Apr 15, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@jeromecoutant
Copy link
Collaborator Author

@jeromecoutant Please review Travis failure, one of the targets fail to pass pinvalidate.

Should be OK now!

0xc0170
0xc0170 previously approved these changes Apr 15, 2021
View reviewed changes
@mbed-ci
Copy link

mbed-ci commented Apr 15, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Apr 15, 2021
@jeromecoutant
STM32: enable PinMap_GPIO table with GPIO_PINMAP_READY
297522b 
If GPIO_PINMAP_READY is defined for the target,
- PinMap_GPIO table is expected in PeripheralPins.c
- weak gpio_get_capabilities function is implemented
@jeromecoutant
DISCO_L475VG_IOT01A: enable PinMap_GPIO[]
4e9ef59
@jeromecoutant
NUCLEO_WB55RG: enable PinMap_GPIO[]
d219378
@mergify mergify bot dismissed 0xc0170’s stale review April 16, 2021 10:40

Pull request has been modified.

@jeromecoutant
Copy link
Collaborator Author

Jenkins CI Test : ❌ FAILED

OK, I have checked FPGA tests, and forgot "normal" tests...
Now it is OK.

I have then re-implemented the function gpio_get_capabilities at ST level.
@LMESTM could you have a look ?
Thx

@jeromecoutant
Copy link
Collaborator Author

Re-start CI ?
Thx

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2021

Marked as needs: CI, will run multiple jobs soon

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 20, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit f2d73e1 into ARMmbed:master Apr 28, 2021
@mergify mergify bot removed the ready for merge label Apr 28, 2021
@jeromecoutant jeromecoutant deleted the PR_GPIO_TABLE branch April 28, 2021 11:49
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
devices: st release-version: 6.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @mbedmain