CMake: support OUTPUT_EXT from targets.json
#14472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Mbed CLI 2 + CMake builds both .bin and .hex images, unless a target specifies OUTPUT_EXT. The post binary hook for ARM_MUSCA_S1 and ARM_MUSCA_B1 is run on .bin images only, so we need to prevent .hex images from being generated and confusing users.
Requires: ARMmbed/mbed-tools#242 The optional `OUTPUT_EXT` field in Mbed OS `targets.json` specifies the format of the output image. This is important because * some targets only support one image format * each post-binary hook outputs one image only This avoids confusion of having both .hex and .bin images generated while only one of them is usable.
3 tasks
ciarmcom
added
the
release-type: patch
|
@LDong-Arm, thank you for your changes. |
2 tasks
|
@adbridge Shall we start CI on this, thanks! |
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Note: This requires ARMmbed/mbed-tools#242 to work fully, but doesn't break compatibility with an older version of mbed-tools in which case the behaviour remains unchanged (i.e. both bin and hex are generated).
The optional
OUTPUT_EXTfield in Mbed OStargets.jsonspecifies the format of the output image. This is important becauseThis avoids confusion of having both .hex and .bin images generated while only one of them is usable.
This PR also sets
OUTPUT_EXTtobinfor ARM_MUSCA_B1 and ARM_MUSCA_S1 as their post-build hook works on the bin file only.Impact of changes
Migration actions required
Documentation
The use of
OUTPUT_EXTis already documented here.Pull request type
Test results
Manually tested with ARMmbed/mbed-tools#242.
Reviewers
@0xc0170 @hugueskamba @rajkan01 @ARMmbed/mbed-b-tools