Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32L1: enable USBDEVICE #14479

Merged
merged 2 commits into from
Apr 7, 2021
Merged

STM32L1: enable USBDEVICE #14479

merged 2 commits into from
Apr 7, 2021

Conversation

chrJost
Copy link
Contributor

@chrJost chrJost commented Mar 26, 2021

Summary of changes

Enables the USBDEVICE for STM32L1 devices.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 26, 2021
@ciarmcom ciarmcom requested a review from a team March 26, 2021 16:00
@ciarmcom
Copy link
Member

@chrJost, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@chrJost
Copy link
Contributor Author

chrJost commented Mar 26, 2021

So far this is just a test pull request, as I don't have a STM32L1 test board. I am waiting for a response from the forum before moving forward:
https://forums.mbed.com/t/usb-device-support-on-stm32l1-is-there-any-chance/12464

@rudolfdobias
Copy link

Tested on NUCLEO_L152RE, seems everything works OK,

@chrJost chrJost marked this pull request as ready for review March 29, 2021 07:24
@chrJost
Copy link
Contributor Author

chrJost commented Mar 29, 2021

There might be some issues with the XDOT_L151CC board, and maybe some other boards, depending on the generator for the main clock. Unfortunately I don't have these boards for testing. I therefore excluded at least the XDOT board from using the USBDEVICE.

@@ -3401,7 +3401,8 @@
"ANALOGOUT",
"SERIAL_ASYNCH",
"FLASH",
"MPU"
"MPU",
"USBDEVICE"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry, but we can't add "USBDEVICE" in the default STM32L1 configuration.
In ARM MBED, "USBDEVICE" doesn't mean that USB device feature is supported,
but means targets has a user USB connector...
You have to add this in you local custom_board.json or mbed_app.json file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I was not aware the board does not have a USB port.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 6, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test
jenkins-ci/mbed-os-ci_greentea-test

@jeromecoutant
Copy link
Collaborator

@0xc0170 need to restart ?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2021

Restarted

@mbed-ci
Copy link

mbed-ci commented Apr 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 84e5f1e into ARMmbed:master Apr 7, 2021
@mergify mergify bot removed the ready for merge label Apr 7, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Apr 26, 2021
@chrJost chrJost deleted the USB_STM32L1 branch June 16, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants