Check for duplicate status callbacks before adding to the list #14497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicate status callbacks don't bring any value and can cause memory leaks if caller calls for this function multiple times with same status_cb. Also remove all the instances of the status_cb when removing event listener.
ciarmcom
added
the
release-type: patch
|
@jarlamsa, thank you for your changes. |
0xc0170
approved these changes
Apr 6, 2021
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
At least the |
|
CI issue, see #14529 (comment) |
|
@0xc0170 can be get this merged? Anything blocking this from next release? |
|
@0xc0170 Is this going to get in sometime soon? This has been waiting over month already. |
|
The CI issue was solved long ago. Rerunning CI on this should be enough. @0xc0170 |
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
Restarted, hw fault |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
Old hook cmake-example-test that was removed, it can be ignored. I'll merge this now. |
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Duplicate status callbacks don't bring any value and can cause
memory leaks if caller calls for this function multiple times with
same status_cb. Also remove all the instances of the status_cb when
removing event listener.
Documentation
None
Pull request type
Test results
Reviewers
@ARMmbed/mbed-os-connectivity