Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding NXP TARGET- MIMXRT1170_EVK #14505

Merged
merged 9 commits into from May 4, 2021
Merged

Adding NXP TARGET- MIMXRT1170_EVK #14505

merged 9 commits into from May 4, 2021

Conversation

s-bruce13
Copy link
Contributor

@s-bruce13 s-bruce13 commented Apr 6, 2021 •
edited by 0xc0170

Summary of changes

Adding Support for the MIMXRT1170_EVK

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

MIMXRT1170_EVK_GCC_ARM_PASSED.txt

Reviewers

@s-bruce13
Adding NXP TARGET- MIMXRT1170_EVK
56450aa 
Base Functionality, UART, Timers, I2C , SPI, ADC
@s-bruce13
Copy link
Contributor Author

@0xc0170 Here is the fresh PR.

@ciarmcom
Copy link
Member

ciarmcom commented Apr 6, 2021

@s-bruce13, thank you for your changes.
@ARMmbed/team-nxp @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team April 6, 2021 16:30
@s-bruce13
Fixed CMake Error
e2c2b2b 
Jenkins CI cmake error
@s-bruce13
Copy link
Contributor Author

s-bruce13 commented Apr 7, 2021 •
edited

@adbridge @0xc0170 Hello hope you are well. is it possible to restart the CI test?

@s-bruce13
Copy link
Contributor Author

@0xc0170 Hello Martin, hope you are well. This is the cleaner PR from the one we had been reviewing , is it possible to get this one reviewed, please.

@mbed-ci
Copy link

mbed-ci commented Apr 13, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️

@s-bruce13
Copy link
Contributor Author

@0xc0170 @gpsimenos Hello both, I am seeing an error in the CI cmake example test referencing the mbed_gpio.c file. This error is similar to one that was previously solved with this #14457 fix. The error is showing that the ARDUINO_ UNO_xx pins are not declared in the scope. I pass all the tests. I also reran the pinvalidate test to make sure and everything is running fine.
python hal/tests/pinvalidate/pinvalidate.py -t MIMXRT1170_EVK -vvv
+-----------------+--------------+-------------+----------+---------------+----------+
| Platform name | Test suite | Test case | Result | Error count | Errors |
+=================+==============+=============+==========+===============+==========+
| MIMXRT1170_EVK | generic | identity | PASSED | 0 | None |
+-----------------+--------------+-------------+----------+---------------+----------+
| MIMXRT1170_EVK | generic | nc | PASSED | 0 | None |
+-----------------+--------------+-------------+----------+---------------+----------+
| MIMXRT1170_EVK | generic | duplicate | PASSED | 0 | None |
+-----------------+--------------+-------------+----------+---------------+----------+
| MIMXRT1170_EVK | generic | legacy | PASSED | 0 | None |
+-----------------+--------------+-------------+----------+---------------+----------+
| MIMXRT1170_EVK | generic | uart | PASSED | 0 | None |
+-----------------+--------------+-------------+----------+---------------+----------+
| MIMXRT1170_EVK | arduino_uno | duplicate | PASSED | 0 | None |
+-----------------+--------------+-------------+----------+---------------+----------+
| MIMXRT1170_EVK | arduino_uno | existence | PASSED | 0 | None |
+-----------------+--------------+-------------+----------+---------------+----------+
| MIMXRT1170_EVK | arduino_uno | nc | PASSED | 0 | None |
+-----------------+--------------+-------------+----------+---------------+----------+

I've tried including the file directly from pinnames.h as well as changing lines in pinnamealiases.h, however the result is the same. Could you please provide any thoughts as to what the problem may be.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2021

The ARDUINO warning should be fixed. But what I see in the failures is:

Error: L6218E: Undefined symbol analogin_init (referred from CMakeFiles/mbed-os-example-blinky.dir/mbed-os/drivers/source/AnalogIn.o).
Error: L6218E: Undefined symbol analogin_read (referred from CMakeFiles/mbed-os-example-blinky.dir/mbed-os/drivers/source/AnalogIn.o).
Error: L6218E: Undefined symbol analogin_read_u16 (referred from CMakeFiles/mbed-os-example-blinky.dir/mbed-os/drivers/source/AnalogIn.o).
Finished: 0 information, 2 warning and 3 error messages.
ninja: build stopped: subcommand failed.

AnalogIn enabled in device_has but no implementation in HAL?

@s-bruce13
Copy link
Contributor Author

@0xc0170 Hi Martin, thank you for the feedback. However, the error I am referring to is not the same one you mention. The one you show above is for the RT1050. I fixed it was missing the analogin_api.c in the cmake list.
The one I am seeing is under the cmake folder for GCC. The ARDUINO messages are not warnings they are showing as errors.

mbed-os-examples_MIMXRT1170_EVK_cmake_GCC_ARM (2).log

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 14, 2021

CI restarted. I've checked the log. I can't see why it fails as the form factor is set properly, pins are defined and the gpio file errors. Lets see if the latest fix changes anything or there is still pinmap issue.

@s-bruce13
Copy link
Contributor Author

Ok, thank you fingers crossed =)

@mbed-ci
Copy link

mbed-ci commented Apr 14, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️

@s-bruce13
Copy link
Contributor Author

@0xc0170 Hi Martin, so it looks like the same error is presented still. It is in both the mbed_gpio.c and mbed_pinmap_default.cpp from the hal/ folder, that the ARDUINO shows as an error and undeclared in the scope. I don't believe the references to these variables are incorrect since the pinvalidate tests can run successfully.
Is this a hard requirement?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2021

@gpsimenos will need to review in detail. I'll check again but I could not spot what is wrong with pinnames in this PR.

Requirement is to have all green so the failure is blocking it.

@gpsimenos
Copy link
Contributor

@gpsimenos will need to review in detail. I'll check again but I could not spot what is wrong with pinnames in this PR.

Requirement is to have all green so the failure is blocking it.

I can't see anything wrong either with pinnames.h, is there any chance it might not be included?

@s-bruce13
Copy link
Contributor Author

@gpsimenos Hello George. I believe it is included as it should be because the tests that make use of the PinNames.h obtain successful results. If I remove the file then they fail as expected.
Is there any other tests I can run on my computer to check this. Or follow the path that it is taking. It would seem to me that the wrong PinName.h is being referenced, is that possible?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 28, 2021

CMake Armclang failed

Error: L6218E: Undefined symbol GPT_GetDefaultConfig (referred from CMakeFiles/mbed-os-example-blinky.dir/mbed-os/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_IMX/lp_ticker.o).
Error: L6218E: Undefined symbol GPT_Init (referred from CMakeFiles/mbed-os-example-blinky.dir/mbed-os/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_IMX/lp_ticker.o).

@mergify mergify bot dismissed 0xc0170’s stale review April 28, 2021 13:15

Pull request has been modified.

@s-bruce13
Copy link
Contributor Author

@0xc0170 @adbridge Hello All, can we please restart the CI?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 29, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 29, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 5 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Apr 29, 2021
@s-bruce13
Copy link
Contributor Author

@0xc0170 Hi Martin, this failed test is new? It wasn't in the previous tests. The failed log is referencing the K64 not the mimxrt1170.

mbedgt: test suite report:

target platform_name test suite result elapsed_time (sec) copy_method
K64F-ARMC6 K64F connectivity-netsocket-tests-tests-network-interface FAIL 90.59 default
mbedgt: test suite results: 1 FAIL
mbedgt: test case report:
target platform_name test suite test case passed failed
------------ --------------- ------------------------------------------------------ ----------------------------------- -------- --------
K64F-ARMC6 K64F connectivity-netsocket-tests-tests-network-interface NETWORKINTERFACE_CONN_DISC_REPEAT 0 0
K64F-ARMC6 K64F connectivity-netsocket-tests-tests-network-interface NETWORKINTERFACE_STATUS 0 1
K64F-ARMC6 K64F connectivity-netsocket-tests-tests-network-interface NETWORKINTERFACE_STATUS_GET 0 0
K64F-ARMC6 K64F connectivity-netsocket-tests-tests-network-interface NETWORKINTERFACE_STATUS_NONBLOCK 0 0
mbedgt: test case results: 3 SKIPPED / 1 FAIL

@s-bruce13
Copy link
Contributor Author

@0xc0170 Hello can we please restart the CI. I believe that this issue is not dependent of my contribution. I have tested a fresh version of arm mbed-os 6.10 and the error is the same.
report_test_greentea_K64F_ARM.log

@0xc0170
Copy link
Contributor

0xc0170 commented May 3, 2021

CI restarted

@mbed-ci
Copy link

mbed-ci commented May 3, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented May 4, 2021

Set this to patch release (adding a new target only)

@0xc0170 0xc0170 merged commit 376fda5 into ARMmbed:master May 4, 2021
@mergify mergify bot removed the ready for merge label May 4, 2021
@stongliang
Copy link

HI,the MIMXRT1170_EVK is enable for Mbed？

@stongliang
Copy link

I want to use MIMXRT1170_EVK with mbed os, is ok?

@0xc0170
Copy link
Contributor

0xc0170 commented May 10, 2021

@stongliang if you use master, you should be able to.

@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@gpsimenos gpsimenos Awaiting requested review from gpsimenos

Assignees
No one assigned
Labels
devices: nxp release-version: 6.11.0 scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@s-bruce13 @ciarmcom @mbed-ci @0xc0170 @gpsimenos @adbridge @stongliang @mbedmain