Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

M487: Resolve WDT reset H/W limit #14567

Merged
merged 3 commits into from May 3, 2021
Merged

M487: Resolve WDT reset H/W limit #14567

merged 3 commits into from May 3, 2021

Conversation

cyliangtw
Copy link
Contributor

Summary of changes

This PR is to resolve the corner case of abnormal repeated interrupt as while M487 watchdog reset from power down mode.

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Apr 20, 2021
@ciarmcom
Copy link
Member

@cyliangtw, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team April 20, 2021 11:30
0xc0170
0xc0170 previously approved these changes Apr 20, 2021
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Apr 20, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 20, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 20, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@mergify mergify bot dismissed 0xc0170’s stale review April 22, 2021 07:04

Pull request has been modified.

@ccli8
Copy link
Contributor

ccli8 commented Apr 22, 2021 •
edited

Make modification:

  1. Rephrase the comment
  2. Pass WDT reset reason test

cyliangtw
cyliangtw commented Apr 22, 2021
View reviewed changes
Copy link
Contributor Author

@cyliangtw cyliangtw left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this refinement for WDT reset reason.

@ccli8
M487: Refine the WKT resolution to WDT reset from PD
e38b691 
1. Rephrase the comment
2. Pass WDT reset reason test
@cyliangtw
Copy link
Contributor Author

@0xc0170 , the last commit is to refine for robustness and passed green-tea test.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit ccde03a into ARMmbed:master May 3, 2021
@mergify mergify bot removed the ready for merge label May 3, 2021
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
devices: nuvoton release-version: 6.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cyliangtw @ciarmcom @0xc0170 @mbed-ci @ccli8 @mbedmain