Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32H7 ADC : dual pad feature update #14733

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Here is an update for dual pad feature:

If pin is one of the dual pad pins (PA0, PA1, PC2 and PC3):

  • if we are using analogin:
    • switch is opened
    • port is configured only for non C pins
  • if we are using other feature:
    • switch is opened only for non C pins
    • port is configured

Discussion started in #14707

Minor update:

  • ALTC define is replaced by DUAL_PAD for better readibility
    (and remove misunderstanding with mbedtls ALT)
  • STM32_gen_PeripheralPins.py updated accordingly

@pennam
@ABOSTM @fpistm

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 3, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Jun 3, 2021

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@pennam
Copy link
Contributor

pennam commented Jun 5, 2021

@jeromecoutant @ABOSTM @fpistm thanks for this update, I've tested it on the PORTENTA and it works great!

@mergify mergify bot added needs: CI and removed needs: review labels Jun 7, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 7, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 7, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 8b1b302 into ARMmbed:master Jun 7, 2021
@mergify mergify bot removed the ready for merge label Jun 7, 2021
@pennam
Copy link
Contributor

pennam commented Jun 8, 2021

FYI @facchinm

@jeromecoutant jeromecoutant deleted the PR_DUALPAD branch June 8, 2021 06:37
@jeromecoutant
Copy link
Collaborator Author

Note that this implementation makes available, for ex, PA1 pin as Ethernet ref clock and PA1_C as analog input in parallel.
But this doesn't forbid user to use PA1_C as GPIO...
Maybe you should implement an additional step? or add explicit comment in some doc that, if Ethernet is used, PA1_C can be only AnalogIn ?
Regards,

@pennam
Copy link
Contributor

pennam commented Jun 8, 2021

Thanks for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants