Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: unit-tests: Make events UNITTESTS only depend on headers it uses #14826

Merged
merged 1 commit into from Jun 25, 2021
Merged

CMake: unit-tests: Make events UNITTESTS only depend on headers it uses #14826

merged 1 commit into from Jun 25, 2021

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jun 24, 2021 •
edited

Summary of changes

Previously the events unit tests depended on mbed-headers, which
is a collection of all available headers in mbed-os and these changes make drivers unit test only depend on the headers it's using.

Impact of changes

None.

Migration actions required

None.

Documentation

To be updated

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@rajkan01
CMake: unit-tests: Make events UNITTESTS only depend on headers it uses
ef5c86f 
Previously the events unit tests depended on `mbed-headers`, which
is a collection of all available headers in mbed-os. To make it easier
to separate the library, only depend on the headers we're using.
@rajkan01 rajkan01 added this to Awaiting review (3) in Mbed Core Jun 24, 2021
@rajkan01 rajkan01 removed this from Awaiting review (3) in Mbed Core Jun 24, 2021
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jun 24, 2021
@ciarmcom ciarmcom requested a review from a team June 24, 2021 10:30
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jun 24, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 24, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 24, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️

@0xc0170 0xc0170 requested a review from LDong-Arm June 24, 2021 14:02
@0xc0170 0xc0170 merged commit 7523945 into master Jun 25, 2021
@mergify mergify bot removed the ready for merge label Jun 25, 2021
@mbedmain mbedmain added release-version: 6.13.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jul 14, 2021
@0xc0170 0xc0170 deleted the events_unittest_header_lib branch October 5, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LDong-Arm LDong-Arm Awaiting requested review from LDong-Arm

Assignees
No one assigned
Labels
component: core release-version: 6.13.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rajkan01 @ciarmcom @0xc0170 @mbed-ci @mbedmain