Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Refactor rtos greentea cmake #14951

Merged
merged 4 commits into from
Sep 2, 2021
Merged

CMake: Refactor rtos greentea cmake #14951

merged 4 commits into from
Sep 2, 2021

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Jul 22, 2021 •
edited
Loading

Summary of changes

Fixes #14942

Initially, every library greentea test has its project() creation in their CMake. As running greentea using CTest move all greentea test suite under one global project mbed-os and MBED_CONFIG_PATH set at the root mbed os CMake under the condition BUILD_GREENTEA_TESTS check so refactored rtos greentea CMake accordingly.

Impact of changes

None.

Migration actions required

None.

Documentation

#15001

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jul 22, 2021
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team July 22, 2021 15:00
@mergify
Copy link

mergify bot commented Jul 23, 2021

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@rajkan01 rajkan01 changed the title CMake: Refactor rtos greentea cmake CMake: Refactor rtos greentea cmake (In progress) Jul 23, 2021
@rajkan01
Copy link
Contributor Author

Pushing some more CMake updates for handling skipping the test

@ciarmcom ciarmcom added the stale Stale Pull Request label Aug 4, 2021
@ciarmcom
Copy link
Member

ciarmcom commented Aug 4, 2021

This pull request has automatically been marked as stale because it has had no recent activity. @rajkan01, please carry out any necessary work to get the changes merged. Thank you for your contributions.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Aug 6, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 12, 2021

This needs to be rebased

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Aug 13, 2021
@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Aug 20, 2021
@rajkan01 rajkan01 force-pushed the refactor_rtos_greentea_cmake branch 2 times, most recently from 391168e to d73cd57 Compare August 23, 2021 12:48
@rajkan01 rajkan01 changed the title CMake: Refactor rtos greentea cmake (In progress) CMake: Refactor rtos greentea cmake Aug 23, 2021
@ciarmcom ciarmcom removed the stale Stale Pull Request label Aug 23, 2021
@rajkan01
CMake: Refactor rtos greentea test CMake
174e016 
Initially, every library greentea test has its project() creation in
their CMake. As running greentea using CTest move all greentea test
suite under one global project mbed-os and MBED_CONFIG_PATH set at
the root mbed os CMake under the condition BUILD_GREENTEA_TESTS
check so refactored rtos greentea CMake accordingly.
@rajkan01
CMake: greentea: Add skip reason to rtos test
5d31b71
@ciarmcom ciarmcom added the stale Stale Pull Request label Aug 26, 2021
@ciarmcom
Copy link
Member

This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please complete review of the changes to move the PR forward. Thank you for your contributions.

@ciarmcom ciarmcom added stale Stale Pull Request and removed stale Stale Pull Request labels Aug 27, 2021
@rajkan01
Copy link
Contributor Author

rajkan01 commented Sep 2, 2021

@0xc0170 Could you review this PR Thanks

LDong-Arm
LDong-Arm previously requested changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajkan01. Just a couple of remarks on macro checks.

rtos/tests/TESTS/mbed_rtos/basic/CMakeLists.txt Outdated Show resolved Hide resolved
rtos/tests/TESTS/mbed_rtos/heap_and_stack/CMakeLists.txt Outdated Show resolved Hide resolved
@mergify mergify bot dismissed LDong-Arm’s stale review September 2, 2021 11:50

Pull request has been modified.

@ciarmcom ciarmcom removed the stale Stale Pull Request label Sep 2, 2021
@mergify mergify bot added needs: CI and removed needs: review labels Sep 2, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 2, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 2, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit fbdf2ff into master Sep 2, 2021
@mergify mergify bot removed the ready for merge label Sep 2, 2021
@mbedmain mbedmain added release-version: 6.15.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 16, 2021
@0xc0170 0xc0170 deleted the refactor_rtos_greentea_cmake branch October 5, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

Assignees
No one assigned
Labels
component: connectivity component: core component: hal component: tools release-version: 6.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CTest support for greentea tests: rtos
6 participants
@rajkan01 @ciarmcom @0xc0170 @mbed-ci @LDong-Arm @mbedmain