Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add target support for XDOT_MAX32670 #15458

Merged
merged 4 commits into from Oct 31, 2023
Merged

Add target support for XDOT_MAX32670 #15458

merged 4 commits into from Oct 31, 2023

Conversation

felser
Copy link
Contributor

@felser felser commented Oct 19, 2023

Summary of changes

Add support for target XDOT_MAX32670

Impact of changes

Migration actions required

Documentation

None

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

Built and tested bootloader and application code for target device.

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[X] Tests / results supplied as part of this PR

Reviewers

0xc0170
0xc0170 previously requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I noticed scancode is failing silently, I should look at how to fix it

targets/TARGET_Maxim/TARGET_MAX32670/TARGET_XDOT_MAX32670/SystemInit.c Show resolved Hide resolved
@mergify mergify bot added the needs: work label Oct 24, 2023
@mergify mergify bot dismissed 0xc0170’s stale review October 24, 2023 15:01

Pull request has been modified.

0xc0170
0xc0170 previously requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional request: Please share the test results as part of the pull request (attached logs)

Otherwise looks good to me

targets/TARGET_Maxim/TARGET_MAX32670/TARGET_XDOT_MAX32670/SystemInit.c Outdated

SystemCoreClock = base_freq >> div;

// base_freq1 = base_freq;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've missed this one , please remove dead code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code removed and pushed.
For test results, what type of logs are you looking for? We built our bootloader code and AT application code for our new LoRaWAN endpoint. We run this combination of code through and extensive series of automated and manual tests. That includes full coverage of our AT commands, LoRaWAN communication and certification, low power modes and firmware updates. This exercises all the onboard hardware of our modules as well as off board SPI and GPIOs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the time we get logs from greentea test run (executing all the tests for a new target). To answer: how was this tested, are all tests green, any known issues?

@mergify mergify bot dismissed 0xc0170’s stale review October 25, 2023 16:38

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 26, 2023

CI started

@mergify mergify bot added needs: CI and removed needs: work labels Oct 26, 2023
@mbed-ci
Copy link

mbed-ci commented Oct 26, 2023

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 72f27ce into ARMmbed:master Oct 31, 2023
20 checks passed
@mergify mergify bot added release version missing When PR does not contain release version, bot should label it and we fix it afterwards and removed ready for merge labels Oct 31, 2023
@mergify
Copy link

mergify bot commented Oct 31, 2023

This PR does not contain release version label after merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release version missing When PR does not contain release version, bot should label it and we fix it afterwards scope: new-target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felser @0xc0170 @mbed-ci