KSDK2 fixes #1817
Merged
KSDK2 fixes #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On repeated starts the flag to indicate this is not being set properly. Because of this the transfer fails. This patch keeps track of the last transfer to determine if a repeated start should be sent and sets the KSDK flags appropriately.
Address passed into the mbed I2C API are expected to be 8 bit and include the read/write flag. KSDK2 expects a 7 bit address without this flag. This patch shifts the address passed into the KSDK by 1 so it is in the correct format.
|
@mbed-bot: TEST HOST_OSES=windows |
|
[Build 419] |
| @@ -108,7 +108,7 @@ int spi_master_write(spi_t *obj, int value) { | |||
| // wait rx buffer full | |||
| while (!spi_readable(obj)); | |||
| rx_data = DSPI_ReadData(spi_address[obj->instance]); | |||
| DSPI_ClearStatusFlags(spi_address[obj->instance], kDSPI_RxFifoDrainRequestFlag); | |||
| DSPI_ClearStatusFlags(spi_address[obj->instance], kDSPI_RxFifoDrainRequestFlag | kDSPI_EndOfQueueFlag); | |||
There was a problem hiding this comment.
This fix should be applied to K22F as well, they share the same peripheral
There was a problem hiding this comment.
Good catch, I'll update it
When the function spi_master_write is called a transfer will occur and set the end of queue flag. This disables further SPI transfers which causes the next SPI transfer to hang forever. This patch clears the end of queue flag so SPI does not hang after the first transfer.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SPI and IIC problems introduced with the switch to KSDK2.