[Exporter/compile tests] Examples test filters #3206
Conversation
| @@ -198,7 +201,7 @@ def print_message(message, name): | |||
| # list of valid combinations to work through | |||
| for target, ide in target_cross_ide(ides, | |||
| example['features'], | |||
| example['targets']): | |||
| example['targets'] or targets): | |||
There was a problem hiding this comment.
I'm pretty sure this needs to be a set intersection instead of an OR since both are valid filters.
There was a problem hiding this comment.
I thought about it, but basically:
example['targets'] can be the empty set, so there would be no intersection :(
| @@ -271,7 +276,8 @@ def compile_repos(config, toolchains): | |||
| # Check that the target, toolchain and features combinations are valid and return a | |||
| # list of valid combinations to work through | |||
| for target, toolchain in target_cross_toolchain(toolchains, | |||
| example['features'], example['targets']): | |||
| example['features'], | |||
| example['targets'] or targets): | |||
There was a problem hiding this comment.
Same thang here, set intersection please!
| @@ -293,7 +305,7 @@ def compile_repos(config, toolchains): | |||
| return results | |||
|
|
|||
|
|
|||
| def update_mbedos_version(config, tag): | |||
| def update_mbedos_version(config, tag, example): | |||
There was a problem hiding this comment.
You've added example here but you're not using it at all. Can you add the continue step in the loop here as well? The do_versionning function will need to be updated in examples.py as well.
| @@ -305,6 +317,8 @@ def update_mbedos_version(config, tag): | |||
| """ | |||
| print("Updating mbed-os in examples to version %s\n" % tag) | |||
| for example in config['examples']: | |||
| if examples['name'] not in examples: | |||
There was a problem hiding this comment.
Lil typo here: examples['name'] should be example['name']
sarahmarshy
force-pushed
the
examples-test-filters
branch
from
1d85a2b
to
dc8a9bb
Compare
|
@sarahmarshy can you resolve the conflicts Any testing needed? |
sarahmarshy
force-pushed
the
examples-test-filters
branch
from
dc8a9bb
to
4bfd73a
Compare
|
@sg- We'll run it through PR testing to make sure the changes don't affect example building. /morph test |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1019 Build failed! |
|
I found an issue with some of the filters in this PR, I went ahead and canceled testing on this PR to allow some other ones through and to get this restarted. /morph test |
|
There seems to be some other deeper issues with the filtering that I'm able to reproduce. I need to investigate this tomorrow even if the CI says it's ok before this is merged. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1022 All builds and test passed! |
bridadan
force-pushed
the
examples-test-filters
branch
from
2173069
to
2fe1373
Compare
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 1027 All builds and test passed! |
Description
Allow command line filtering of targets and examples for both compile and export tests.
Status
READY
Todos