Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: Refactor lp_ticker.c + rtc_api.c + sleep.c + rtc_api_hal.h files #3316

Closed
wants to merge 2 commits into from

Conversation

jeromecoutant
Copy link
Collaborator

Description

The goal of this PR is to refactor 4 files :

  • lp_ticker.c
  • rtc_api.c
  • sleep.c
  • rtc_api_hal.h

Now only 4 files are used for all the STM32 devices and placed in TARGET_STM folder

Status

READY

Test status

OS2 and OS5 Tests have been checked with all family targets

@bridadan
Copy link
Contributor

Gotta love that diff! Nice work @jeromecoutant 😄

/morph test

@mbed-bot
Copy link

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1160

Build failed!

@bridadan
Copy link
Contributor

Sorry for the abort, I forgot the normal tests don't touch the LP timers. Starting a full nightly now.

/morph test-nightly

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1161

All builds and test passed!

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

[Build 1144]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

int rtc_isenabled(void)
{
#if DEVICE_LOWPOWERTIMER
if ((RTC->ISR & RTC_ISR_INITS) == RTC_ISR_INITS)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be as it was if () { , starting { on the same line

RCC_OscInitStruct.LSIState = RCC_LSI_OFF;

if (HAL_RCC_OscConfig(&RCC_OscInitStruct) == HAL_OK)
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, the code style

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 5, 2016

Bump

@jeromecoutant
Copy link
Collaborator Author

I ran astyle script

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 7, 2016

/morph test

@mbed-bot
Copy link

mbed-bot commented Dec 7, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1212

All builds and test passed!

@bridadan
Copy link
Contributor

bridadan commented Dec 8, 2016

We should run the nightly on this so the LP ticker tests are ran.

/morph test-nightly

@mbed-bot
Copy link

mbed-bot commented Dec 8, 2016

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1228

All builds and test passed!

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 16, 2016

I've sent the replacement #3454 that is rebased on top of master to resolve CI issue we are seeing. I'll close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants