nsapi - Fixed open/close issue in Socket #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During open, the socket checked the internal stack variable, assuming it would alway be null on a socket not connected to the network. However, when a socket is closed, the stack variable was not updated, causing the socket to incorrectly return a parameter error if reopened. The simple fix was to set the stack to null on close. A non-null stack is a predicate for a non-null socket variable, so no additional checks are needed in socket functions.
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
0xc0170
approved these changes
Dec 9, 2016
|
retest uvisor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During open, the socket checked the internal stack variable, assuming it would alway be null on a socket not connected to the network. However, when a socket is closed, the stack variable was not updated, causing the socket to incorrectly return a parameter error if reopened.
The simple fix was to set the stack to null on close. A non-null stack is a predicate for a non-null socket variable, so no additional checks are needed in socket functions.
Required for #3265