-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target: Add new target UBLOX_EVK_NINA_B1 #3459
Target: Add new target UBLOX_EVK_NINA_B1 #3459
Conversation
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
CI passed @mazgch Any review? |
This UBLOX_EVK_NINA_B1 is an additional target. You should not modify the UBLOX_EVA_NINA target. Why do you remove the "SERIAL_FC", the target does support flow control functionality, it is just the DAPLINK hardware on the UBLOX_EVA_NINA target that does not support this on the USBRX/TX but it might still be used for any other 4 wire UART. So SERIAL_FC should be present on both boards/targets. |
It was not clear from the previous PR, I was not certain about the diff. Thanks, going to fix it. |
Based on nrf51 MCU.
6f4c1bd
to
b1a9e7b
Compare
Pushed the update, please review @mazgch |
looks good! |
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
I wasn't able to reproduce the failure locally, I'll go ahead and run the tests once more to be sure it wasn't an infrastructure issue. /morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
Well that definitely was an infrastructure issue! PermGen space issues again with Jenkins. /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Ok, if all reviewers are happy this should be good to go |
Ports for Upcoming Targets 3459: Target: Add new target UBLOX_EVK_NINA_B1 ARMmbed/mbed-os#3459 Fixes and Changes 3430: Fix ci shield eeprom test ARMmbed/mbed-os#3430 3381: STM32F1 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3381 3389: STM32F2 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3389 3390: STM32F3 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3390 3410: STM32L4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3410 3422: Enable CAN on DISCO_F303VC ARMmbed/mbed-os#3422 3442: Dev stm i2c f1 ARMmbed/mbed-os#3442 3460: KSDK I2C: Update the return value to match the API documentation change ARMmbed/mbed-os#3460 3472: [RZ/A1H]Fix TTB setting of RO_DATA area ARMmbed/mbed-os#3472 3451: Rename KSDK2 to MCUXpresso. This is the new name of this package ARMmbed/mbed-os#3451 3391: STM32F4 : map ST HAL assert into MBED assert ARMmbed/mbed-os#3391 3454: STM32: Refactor lp_ticker.c + rtc_api.c + sleep.c + rtc_api_hal.h files ARMmbed/mbed-os#3454 3489: NUCLEO_F103RB - Correct CAN and PWM alternate-functions ARMmbed/mbed-os#3489 3405: Repair the transmit mailbox (0,1,2) empty interrupt flag not clear BUG ARMmbed/mbed-os#3405 3502: MCUXpresso I2C: Handle 0 byte write ARMmbed/mbed-os#3502 3365: [NUC472/M453] Support USB device ARMmbed/mbed-os#3365
Rebased #3328 and squashed into one commit
cc @mazgch - please check if targets/targets.json is rebased properly