Turn on debugging by default when exporting. Remove optimizations for IAR and Uvision #3534

sarahmarshy · 2017-01-05T16:01:46Z

Description

This PR will turn on flags for debug symbols for all exporters.

It also removes optimization flags from the compiler flags, as those are set in the IDE by the user. If they exist as a hard-coded flag, the user will not be able to use the IDE to turn them off, and instead will have to manually search through the considerably long compiler flags to turn them off (if they realize they their IDE setting did nothing). Not a big deal in some exporters, but uvision makes them into a single text box in the GUI, so you just have to arrow over.

@janjongboom @theotherjimmy

Status

READY

Migrations

Now, if users do not want debug flags when exporting, they should use:
mbed export --profile default

Related: #3532
This is a more generalized version for all the exporters.

Todos

Tests
Reviewers

theotherjimmy · 2017-01-05T16:06:14Z

tools/project.py

@@ -175,7 +175,7 @@ def main():
                        type=argparse_profile_filestring_type,
                        help="Build profile to use. Can be either path to json" \
                        "file or one of the default one ({})".format(", ".join(list_profiles())),
-                        default=[])
+                        default=[argparse_profile_filestring_type('debug')])


I don't think this will do what you seem to think. I think it will always start with the debug profile and merge all of the profiles specified on the command line. That's not quite what we want here.

What we want here is for the default to be the debug profile.

theotherjimmy · 2017-01-05T16:16:58Z

/morph export-build

theotherjimmy

I fixed it :)

mbed-bot · 2017-01-05T16:59:23Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 68

Exporter Build failed!

0xc0170 · 2017-01-06T07:33:21Z

Please split the first commit into 2 logical separated commits:

Turn on debugging by default when exporting
Remove optimizations for IAR and Uvision

0xc0170 · 2017-01-06T07:37:16Z

tools/export/uvision/uvision.tmpl

@@ -351,7 +351,7 @@
          </ArmAdsMisc>
          <Cads>
            <interw>0</interw>
-            <Optim>2</Optim>


a reason for this? shall be a separate commit?

Turns off optimizations by default.

0xc0170 · 2017-01-09T13:31:13Z

Please split the first commit into 2 logical separated commits:
Turn on debugging by default when exporting
Remove optimizations for IAR and Uvision

@sarahmarshy Can you please?

sarahmarshy · 2017-01-10T21:35:18Z

@0xc0170 They are split now.

bridadan · 2017-01-11T16:17:33Z

/morph export-build

mbed-bot · 2017-01-11T16:57:20Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 78

Exporter Build failed!

bridadan · 2017-01-11T17:58:27Z

@sarahmarshy It looks like there are some ST devices that are failing to compile in debug mode, and I have a feeling that these are probably present when compiling with the mbed build system as well.

Would you mind trying the following and seeing if it fails? This failed with make_iar in the CI system.

mbed import mbed-os-example-mesh-minimal
cd mbed-os-example-mesh-minimal
mbed compile -m DISCO_F746NG -t IAR --profile debug

EDIT: This is the error I'm seeing in CI:

10:35:02 "C:\Jenkins\workspace\bm_wrap\1416\examples\mbed-os-example-mesh-minimal\mbed-os\features\FEATURE_LWIP\lwip-interface\lwip\src\include\lwip\arch.h",70  Warning[Pe301]: typedef name has already been declared (with same type)
10:35:02 Error[Li005]: no definition for "get_i2c_timing" [referenced from C:\Jenkins\wo
10:35:02           rkspace\bm_wrap\1416\examples\mbed-os-example-mesh-minimal\BUILD\mbed
10:35:02           -os\targets\TARGET_STM\i2c_api.o]
10:35:02 make[1]: *** [mbed-os-example-mesh-minimal.elf] Error 2
10:35:02 make: *** [all] Error 2

sarahmarshy · 2017-01-12T16:15:36Z

Results:

GCC_ARM:

mbed compile -m DISCO_F746NG -t GCC_ARM --profile debug


Compiling stuff.....
....
Link: mbed-os-example-mesh-minimal
./.build/DISCO_F746NG/gcc_arm/mbed-os/targets/TARGET_STM/i2c_api.o: In function `i2c_frequency':
C:\Repos\mbed-os-example-mesh-minimal/.\mbed-os\targets\TARGET_STM/i2c_api.c:363: undefined reference to `get_i2c_timing'
collect2.exe: error: ld returned 1 exit status
[ERROR] ./.build/DISCO_F746NG/gcc_arm/mbed-os/targets/TARGET_STM/i2c_api.o: In function `i2c_frequency':
C:\Repos\mbed-os-example-mesh-minimal/.\mbed-os\targets\TARGET_STM/i2c_api.c:363: undefined reference to `get_i2c_timing'
collect2.exe: error: ld returned 1 exit status

IAR:

mbed compile -m DISCO_F746NG -t IAR --profile debug


Compiling stuff.....
....
Link: mbed-os-example-mesh-minimal
Error[Li005]: no definition for "get_i2c_timing" [referenced from C:\Repos\mbed
          -os-example-mesh-minimal\.build\DISCO_F746NG\IAR\mbed-os\targets\TARG
          ET_STM\i2c_api.o]
[ERROR] Error[Li005]: no definition for "get_i2c_timing" [referenced from C:\Repos\mbed
          -os-example-mesh-minimal\.build\DISCO_F746NG\IAR\mbed-os\targets\TARG
          ET_STM\i2c_api.o]

bridadan · 2017-01-13T19:58:16Z

The export-build failure should be fixed now with #3577 being merged.

/morph export-build

mbed-bot · 2017-01-13T23:46:01Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 81

All exports and builds passed!

theotherjimmy suggested changes Jan 5, 2017

View reviewed changes

theotherjimmy approved these changes Jan 5, 2017

View reviewed changes

0xc0170 reviewed Jan 6, 2017

View reviewed changes

bridadan added needs: CI needs: work labels Jan 9, 2017

sarahmarshy and others added 2 commits January 10, 2017 15:30

Turn off optimizations for uvision and IAR

54fd40f

Make the debug profile the default used for exporting

2bf1f6b

sarahmarshy force-pushed the export-debug branch from de592be to 2bf1f6b Compare January 10, 2017 21:34

bridadan mentioned this pull request Jan 12, 2017

Fixes linking errors when building with debug profile #3577

Merged

1 task

0xc0170 added release-version: 5.3.4 and removed needs: CI needs: work labels Jan 16, 2017

0xc0170 merged commit 04a31f3 into ARMmbed:master Jan 16, 2017

adbridge added release-version: 5.3.4 and removed release-version: 5.3.4 labels Jan 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turn on debugging by default when exporting. Remove optimizations for IAR and Uvision #3534

Turn on debugging by default when exporting. Remove optimizations for IAR and Uvision #3534

sarahmarshy commented Jan 5, 2017 •

edited

Loading

theotherjimmy Jan 5, 2017

theotherjimmy commented Jan 5, 2017

theotherjimmy left a comment

mbed-bot commented Jan 5, 2017

0xc0170 commented Jan 6, 2017

0xc0170 Jan 6, 2017

sarahmarshy Jan 6, 2017

0xc0170 commented Jan 9, 2017

sarahmarshy commented Jan 10, 2017

bridadan commented Jan 11, 2017

mbed-bot commented Jan 11, 2017

bridadan commented Jan 11, 2017 •

edited

Loading

sarahmarshy commented Jan 12, 2017

bridadan commented Jan 13, 2017

mbed-bot commented Jan 13, 2017

Turn on debugging by default when exporting. Remove optimizations for IAR and Uvision #3534

Turn on debugging by default when exporting. Remove optimizations for IAR and Uvision #3534

Conversation

sarahmarshy commented Jan 5, 2017 • edited Loading

Description

Status

Migrations

Todos

theotherjimmy Jan 5, 2017

Choose a reason for hiding this comment

theotherjimmy commented Jan 5, 2017

theotherjimmy left a comment

Choose a reason for hiding this comment

mbed-bot commented Jan 5, 2017

Result: FAILURE

Output

0xc0170 commented Jan 6, 2017

0xc0170 Jan 6, 2017

Choose a reason for hiding this comment

sarahmarshy Jan 6, 2017

Choose a reason for hiding this comment

0xc0170 commented Jan 9, 2017

sarahmarshy commented Jan 10, 2017

bridadan commented Jan 11, 2017

mbed-bot commented Jan 11, 2017

Result: FAILURE

Output

bridadan commented Jan 11, 2017 • edited Loading

sarahmarshy commented Jan 12, 2017

bridadan commented Jan 13, 2017

mbed-bot commented Jan 13, 2017

Result: SUCCESS

Output

sarahmarshy commented Jan 5, 2017 •

edited

Loading

bridadan commented Jan 11, 2017 •

edited

Loading