New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable verbose builds when running example build tests #4530

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
6 participants
@bridadan
Contributor

bridadan commented Jun 12, 2017

Description

Currently when building examples in CI, the following command is run for each TARGET, TOOLCHAIN, and EXAMPLE combination:

cd <EXAMPLE> && mbed compile -t <TOOLCHAIN> -m <TARGET> --silent

The --silent hides valuable debug information when certain errors occur. This PR enables verbose mode to reveal this information. The command will now become:

cd <EXAMPLE> && mbed compile -t <TOOLCHAIN> -m <TARGET> -v

Status

READY

Todos

  • morph test

FYI @c1728p9

@bridadan bridadan requested review from theotherjimmy and c1728p9 Jun 12, 2017

@theotherjimmy

Looks great. -v might be too much, and might slow things down.

@bridadan

This comment has been minimized.

Contributor

bridadan commented Jun 12, 2017

retest uvisor

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 13, 2017

Looks great. -v might be too much, and might slow things down.

what would you suggest @theotherjimmy ?

I believe this is the one I reported yesterday, that examples show Error but not actual error, this should fix it ? It would be enough to report errors , I assume this PR is fixing that?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 13, 2017

retest uvisor

@bridadan

This comment has been minimized.

Contributor

bridadan commented Jun 13, 2017

We have verbose turned on for compiles, so not too much different here. I'd recommend doing a CI run to see how it affects the compile time. (normal morph test)

@bridadan

This comment has been minimized.

Contributor

bridadan commented Jun 13, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 13, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 542

All builds and test passed!

@bridadan

This comment has been minimized.

Contributor

bridadan commented Jun 13, 2017

If you look at the Jenkins results, it looks like the "Example Build" stage slowed down by 15 minutes, but that's not actually true. What actually happened was the "Example Build" stage was started, then blocked for 15 minutes because another build was executing. The actual building still took ~20 minutes.

So looks like this should be ok!

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 15, 2017

@sg- sg- merged commit 74b6e8c into ARMmbed:master Jun 15, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sg- sg- removed the ready for merge label Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment