New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable verbose builds when running example build tests #4530
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. -v might be too much, and might slow things down.
retest uvisor |
what would you suggest @theotherjimmy ? I believe this is the one I reported yesterday, that examples show Error but not actual error, this should fix it ? It would be enough to report errors , I assume this PR is fixing that? |
retest uvisor |
We have verbose turned on for compiles, so not too much different here. I'd recommend doing a CI run to see how it affects the compile time. (normal morph test) |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
If you look at the Jenkins results, it looks like the "Example Build" stage slowed down by 15 minutes, but that's not actually true. What actually happened was the "Example Build" stage was started, then blocked for 15 minutes because another build was executing. The actual building still took ~20 minutes. So looks like this should be ok! |
Description
Currently when building examples in CI, the following command is run for each TARGET, TOOLCHAIN, and EXAMPLE combination:
The
--silent
hides valuable debug information when certain errors occur. This PR enables verbose mode to reveal this information. The command will now become:Status
READY
Todos
FYI @c1728p9