-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix style issues in IAR exporter #4598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This does not change it, just for future that in our codebase: tgt
vs target
, we shall use full name for readability (of course if its not 50 characters long)
Travis failure
|
Huh. |
No we "shall" not. target can be a function name. If it is, don't create a local variable that shadows it. |
f074069
to
14a0fb7
Compare
/morph export-build |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 74 All exports and builds passed! |
@0xc0170 and I discussed variable naming offline, and came to the conclusion that |
Some of this stuff began to bother me, so I fixed it.