New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tests for RTOS Thread class #4620

Merged
merged 5 commits into from Jul 17, 2017

Conversation

Projects
None yet
5 participants
@bulislaw
Member

bulislaw commented Jun 22, 2017

Description

During the CMSIS/RTX update, it became obvious that our test coverage is quite poor. This PR tries to extend tests to all Thread functions. It also fixes issues found during tests development.

Status

READY

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jun 22, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 22, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 614

Build failed!

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jun 23, 2017

/morph test

@pan-

Good initiative 👍 . Would it be possible to document precisely what every case test ? given, when, then structure might help to structure formally context, operation tested and expected result.

Another point, maybe it would be interresting to plug our tests with the RTX event system to do even more verifications.

TESTS/mbedmicro-rtos-mbed/threads/main.cpp Outdated
@@ -108,37 +108,302 @@ void test_self_terminate() {
delete thread;
}
void wait_set_signal(Thread *t) {

This comment has been minimized.

@pan-

pan- Jun 23, 2017

Member

Is it possible to split out cases and group together in a class various functions involved during the test case ?

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 23, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 627

Test failed!

@bulislaw bulislaw force-pushed the bulislaw:thread_tests branch Jun 27, 2017

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jun 27, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 28, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 660

Test failed!

@bulislaw bulislaw force-pushed the bulislaw:thread_tests branch to 60e7ef2 Jun 29, 2017

@bulislaw bulislaw removed the do not merge label Jun 29, 2017

@bulislaw bulislaw changed the title from [RFC] Extend tests for RTOS Thread class to Extend tests for RTOS Thread class Jun 29, 2017

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jun 29, 2017

/morph test

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jun 29, 2017

@0xc0170 please review

@mbed-bot

This comment has been minimized.

mbed-bot commented Jun 29, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 688

All builds and test passed!

@0xc0170

0xc0170 approved these changes Jul 4, 2017 edited

if you can fix void test_thread_wait() { , { on the new line

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 4, 2017

Good initiative 👍 . Would it be possible to document precisely what every case test ? given, when, then structure might help to structure formally context, operation tested and expected result.

I believe this was addressed, happy @pan- with this patch?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 10, 2017

@pan- Could you review?

@bulislaw

This comment has been minimized.

Member

bulislaw commented Jul 17, 2017

@pan- @0xc0170 ping!

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 17, 2017

@pan- Could you review?

@theotherjimmy theotherjimmy merged commit 18bb6fd into ARMmbed:master Jul 17, 2017

5 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment