Extend tests for RTOS Thread class #4620
Conversation
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
/morph test |
There was a problem hiding this comment.
Good initiative 👍 . Would it be possible to document precisely what every case test ? given, when, then structure might help to structure formally context, operation tested and expected result.
Another point, maybe it would be interresting to plug our tests with the RTX event system to do even more verifications.
| @@ -108,37 +108,302 @@ void test_self_terminate() { | |||
| delete thread; | |||
| } | |||
|
|
|||
| void wait_set_signal(Thread *t) { | |||
There was a problem hiding this comment.
Is it possible to split out cases and group together in a class various functions involved during the test case ?
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
Signal wait was always returning success even in case of error.
bulislaw
changed the title
|
/morph test |
|
@0xc0170 please review |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
I believe this was addressed, happy @pan- with this patch? |
|
@pan- Could you review? |
|
@pan- Could you review? |
Description
During the CMSIS/RTX update, it became obvious that our test coverage is quite poor. This PR tries to extend tests to all Thread functions. It also fixes issues found during tests development.
Status
READY