-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sleep API update (branch feature-hal-spec-sleep) #5053
Sleep API update (branch feature-hal-spec-sleep) #5053
Conversation
Sleep - within 10us Deepsleep - within 10ms Note about mbed boards with interface, moved to lpc176x, as they are target related, should be documented in the target documentation. The tests will come as separate PR, to conform to this updates to sleep API.
Could you move it to sleep specific branch? |
The branch updated |
To fix travis, we will need to rebase the branch to get the fix for travis in. Update: should be in now there, reopening |
bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@c1728p9 Happy with this? Please review /morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
/morph test |
Are we ready to merge this PR to a branch? |
@bulislaw When morph test gets back to us, yes. |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
This goes to feature-hal-spec branch, update to sleep API. This was previously part of sleep manager, but should come as separate patch that will require testing and further target updates.
Sleep - within 10us
Deepsleep - within 10ms
Note about mbed boards with interface, moved to lpc176x, as they are target related,
should be documented in the target documentation.
The tests will come as separate PR, to conform to this updates to sleep API.
cc @bulislaw @c1728p9