Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep API update (branch feature-hal-spec-sleep) #5053

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Sep 8, 2017

This goes to feature-hal-spec branch, update to sleep API. This was previously part of sleep manager, but should come as separate patch that will require testing and further target updates.

Sleep - within 10us
Deepsleep - within 10ms

Note about mbed boards with interface, moved to lpc176x, as they are target related,
should be documented in the target documentation.

The tests will come as separate PR, to conform to this updates to sleep API.

cc @bulislaw @c1728p9

Sleep - within 10us
Deepsleep - within 10ms

Note about mbed boards with interface, moved to lpc176x, as they are target related,
should be documented in the target documentation.

The tests will come as separate PR, to conform to this updates to sleep API.
@bulislaw
Copy link
Member

bulislaw commented Sep 8, 2017

Could you move it to sleep specific branch? feature-hal-spec-sleep we want vendors to tackle them one by one and not gate stuff on not complete implementations.

@0xc0170 0xc0170 changed the base branch from feature-hal-spec to feature-hal-spec-sleep September 8, 2017 11:11
@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 8, 2017

The branch updated

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 11, 2017

To fix travis, we will need to rebase the branch to get the fix for travis in.

Update: should be in now there, reopening

@0xc0170 0xc0170 closed this Sep 11, 2017
@0xc0170 0xc0170 reopened this Sep 11, 2017
@theotherjimmy theotherjimmy changed the title Sleep API update Sleep API update (branch feature-hal-spec-sleep) Sep 25, 2017
@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 27, 2017

bump

Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Sep 29, 2017

@c1728p9 Happy with this? Please review

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1446

Test failed!

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 2, 2017

/morph test

@bulislaw
Copy link
Member

bulislaw commented Oct 2, 2017

Are we ready to merge this PR to a branch?

@theotherjimmy
Copy link
Contributor

@bulislaw When morph test gets back to us, yes.

@mbed-bot
Copy link

mbed-bot commented Oct 2, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1493

All builds and test passed!

@adbridge adbridge merged commit 6f24340 into ARMmbed:feature-hal-spec-sleep Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants