New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL8195AM - Fix and cleanup mbed_rtx.h #5232

Merged
merged 2 commits into from Oct 9, 2017

Conversation

Projects
None yet
5 participants
@tung7970
Contributor

tung7970 commented Oct 2, 2017

Description

Fix ARMC6 guard and cleanup mbed_rtx.h

Status

READY

Migrations

NO

Related PRs

NONE

Todos

NONE

Deploy notes

NONE

Steps to test or reproduce

NONE

rtl8195am - remove obsolete configs
The following configs were no longer necessary for RTX5.
    OS_TASKCNT
    OS_MAINSTKSIZE
    OS_CLOCK

Signed-off-by: Tony Wu <tonywu@realtek.com>

@tung7970 tung7970 force-pushed the tung7970:fix-target branch Oct 2, 2017

@@ -33,8 +33,7 @@
#define INITIAL_SP (__StackTop)
#endif


#if defined(__CC_ARM) || defined(__GNUC__)

This comment has been minimized.

@0xc0170

0xc0170 Oct 2, 2017

Member

Was this redundant ? ISR_STACK_SIZE can be set for ARMCC or ARM GCC (see mbed boot code file)

This comment has been minimized.

@tung7970

tung7970 Oct 2, 2017

Contributor

@0xc0170 ISR_STACK_SIZE is always set in the case of CC_ARM and ARMCC above.

This comment has been minimized.

@0xc0170

0xc0170 Oct 2, 2017

Member

I see now. Then this should be moved to the above (ARMCC provides gnu flag that defines also GNUC macro that we use) or be completely removed? I would say to be removed, the default stack size is set. Thus not needed here ?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2017

@0xc0170

0xc0170 approved these changes Oct 2, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Oct 2, 2017

@tung7970 Could you change the sha of the last commit to kick out Circle CI? You can do this with git commit --amend with no changes.

rtl8195am - fix ARMC6 guards
Fix ARMC6 guard typo introduced in commit 4f3f0cc (Make Realtek link)

While at it, remove redundant ISR_STACK_SIZE assignment for ARMCC.

Signed-off-by: Tony Wu <tonywu@realtek.com>

@tung7970 tung7970 force-pushed the tung7970:fix-target branch to d0de5f7 Oct 2, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 5, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 5, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1527

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 7, 2017

@theotherjimmy theotherjimmy merged commit ad13457 into ARMmbed:master Oct 9, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment