RTL8195AM - Fix and cleanup mbed_rtx.h #5232
Conversation
The following configs were no longer necessary for RTX5.
OS_TASKCNT
OS_MAINSTKSIZE
OS_CLOCK
Signed-off-by: Tony Wu <tonywu@realtek.com>
| @@ -33,8 +33,7 @@ | |||
| #define INITIAL_SP (__StackTop) | |||
| #endif | |||
|
|
|||
|
|
|||
| #if defined(__CC_ARM) || defined(__GNUC__) | |||
There was a problem hiding this comment.
Was this redundant ? ISR_STACK_SIZE can be set for ARMCC or ARM GCC (see mbed boot code file)
There was a problem hiding this comment.
@0xc0170 ISR_STACK_SIZE is always set in the case of CC_ARM and ARMCC above.
There was a problem hiding this comment.
I see now. Then this should be moved to the above (ARMCC provides gnu flag that defines also GNUC macro that we use) or be completely removed? I would say to be removed, the default stack size is set. Thus not needed here ?
|
@tung7970 Could you change the sha of the last commit to kick out Circle CI? You can do this with |
Fix ARMC6 guard typo introduced in commit 4f3f0cc (Make Realtek link) While at it, remove redundant ISR_STACK_SIZE assignment for ARMCC. Signed-off-by: Tony Wu <tonywu@realtek.com>
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Description
Fix ARMC6 guard and cleanup mbed_rtx.h
Status
READY
Migrations
NO
Related PRs
NONE
Todos
NONE
Deploy notes
NONE
Steps to test or reproduce
NONE