New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUCLEO_L432KC: Fixed async serial #5535

Merged
merged 2 commits into from Nov 22, 2017

Conversation

Projects
None yet
6 participants
@MikeDK
Contributor

MikeDK commented Nov 20, 2017

Description

In targets.json there is no SERIAL_ASYNC defined for the NUCLEO_L432KC developer board.
When adding this option, a bug in targets/TARGET_STM/TARGET_STM32L4 was encountered which was leading to compile errors.

@MikeDK

This comment has been minimized.

Contributor

MikeDK commented Nov 20, 2017

PS: sorry about the duplicate pull request ... i was not able to remove the unnecessary merge commit ... i did a reset to the mbed-os master, which removed my commits and thus automatically closed the previous pull request ;)

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 20, 2017

@MikeDK Thanks ! Good to see that coming from a branch, you can now use master to follow upstream/master 💯

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 20, 2017

@ARMmbed/team-st-mcd Please review

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 20, 2017

@MikeDK any tests done with this fix?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 20, 2017

/morph test

@bcostm

bcostm approved these changes Nov 20, 2017

@MikeDK

This comment has been minimized.

Contributor

MikeDK commented Nov 20, 2017

@0xc0170 Yes I did some testing with the logger class I wrote for our project. The class supports blocking and non-blocking output (the latter is useful for logging something from within interrupt context) and both is working like a charm with the fix.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 20, 2017

/morph build.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Nov 20, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 20, 2017

Build : SUCCESS

Build number : 561
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5535/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

1 similar comment
@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 20, 2017

Build : SUCCESS

Build number : 561
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5535/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Nov 22, 2017

@theotherjimmy theotherjimmy merged commit 369187c into ARMmbed:master Nov 22, 2017

6 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment