New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for default test config file #5559

Merged
merged 6 commits into from Dec 20, 2017

Conversation

Projects
None yet
7 participants
@yennster
Contributor

yennster commented Nov 22, 2017

Description

Fixes #5543

This change allows for mbed test to build with an mbed_app.json file by default if one exists in the project's root directory (i.e. for running the ci-test-shield tests). However, if the mbed_app.json file is not in the root directory, then it's location needs to be specified in the command with the --app-config parameter.

Steps to test or reproduce

Before fix:
If you run the ci-test-shield tests with mbed test -t GCC_ARM -m NUCLEO_F207ZG -n tests* --compile without a specified --app-config you get the following errors related to the unspecified mbed_app.json:

        [Error] Mixed.cpp@68,22: 'MBED_CONF_APP_I2C_SDA' was not declared in this scope
        [Error] Mixed.cpp@68,44: 'MBED_CONF_APP_I2C_SCL' was not declared in this scope
        [Error] Mixed.cpp@68,66: 'MBED_CONF_APP_I2C_EEPROM_ADDR' was not declared in this scope
        ...

After fix:
If you run the ci-test-shield tests with mbed test -t GCC_ARM -m NUCLEO_F207ZG -n tests* --compile without a specified --app-config, if there exists an mbed_app.json in the root directory of the project then the tests compile and run successfully.

@yennster

This comment has been minimized.

Contributor

yennster commented Nov 22, 2017

@sarahmarshy @geky related to #5543

@0xc0170 0xc0170 requested review from sarahmarshy and theotherjimmy Nov 23, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 23, 2017

@jeromecoutant Does this fix the issue you reported?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 23, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Nov 23, 2017

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Nov 23, 2017

Hi
Yes, issue #5543 can be closed with that patch
Thx

@0xc0170 0xc0170 added needs: work and removed needs: review labels Nov 23, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Nov 23, 2017

Building fails, please review the latest results

@yennster yennster force-pushed the yennster:tools-config-fix branch to d438324 Dec 1, 2017

@yennster

This comment has been minimized.

Contributor

yennster commented Dec 1, 2017

Fixed with help from @theotherjimmy
@0xc0170

yennster and others added some commits Dec 1, 2017

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Dec 6, 2017

Quick tests with the last version:

  • OK in mbed-os environment
  • OK in ci-shield environment

Thx Jenny

@jeromecoutant

This comment has been minimized.

Contributor

jeromecoutant commented Dec 7, 2017

Minor question about the TODO comment https://github.com/yennster/mbed-os/blob/b3ba9a55b900058c3317f707bc867c91ff70fb84/tools/test.py#L141

Is this patch correcting it ?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Dec 7, 2017

@jeromecoutant This patch does not touch that code or remove that comment. No, it does not correct that TODO.

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Dec 8, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 8, 2017

/morph build

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 8, 2017

@theotherjimmy Are you happy with this patch?

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Dec 8, 2017

@0xc0170 The last commit is mine :P

@yennster

This comment has been minimized.

Contributor

yennster commented Dec 8, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Dec 11, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 11, 2017

Build : SUCCESS

Build number : 674
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5559/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Dec 11, 2017

@kegilbert That export failure is not showing any failed exports. Could you take a look?

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Dec 11, 2017

@theotherjimmy Looks like a node went down midrun on one of the boards, rekicking off.
/morph export-build

@mbed-ci

This comment has been minimized.

mbed-ci commented Dec 11, 2017

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Dec 13, 2017

@0xc0170 0xc0170 merged commit 203fc36 into ARMmbed:master Dec 20, 2017

10 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2 Local mbed2 testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment