Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for default test config file #5559

Merged
merged 6 commits into from
Dec 20, 2017
Merged

Conversation

yennster
Copy link
Contributor

@yennster yennster commented Nov 22, 2017

Description

Fixes #5543

This change allows for mbed test to build with an mbed_app.json file by default if one exists in the project's root directory (i.e. for running the ci-test-shield tests). However, if the mbed_app.json file is not in the root directory, then it's location needs to be specified in the command with the --app-config parameter.

Steps to test or reproduce

Before fix:
If you run the ci-test-shield tests with mbed test -t GCC_ARM -m NUCLEO_F207ZG -n tests* --compile without a specified --app-config you get the following errors related to the unspecified mbed_app.json:

        [Error] Mixed.cpp@68,22: 'MBED_CONF_APP_I2C_SDA' was not declared in this scope
        [Error] Mixed.cpp@68,44: 'MBED_CONF_APP_I2C_SCL' was not declared in this scope
        [Error] Mixed.cpp@68,66: 'MBED_CONF_APP_I2C_EEPROM_ADDR' was not declared in this scope
        ...

After fix:
If you run the ci-test-shield tests with mbed test -t GCC_ARM -m NUCLEO_F207ZG -n tests* --compile without a specified --app-config, if there exists an mbed_app.json in the root directory of the project then the tests compile and run successfully.

@yennster
Copy link
Contributor Author

@sarahmarshy @geky related to #5543

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2017

@jeromecoutant Does this fix the issue you reported?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 23, 2017

Build : FAILURE

Build number : 579
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5559/

@jeromecoutant
Copy link
Collaborator

Hi
Yes, issue #5543 can be closed with that patch
Thx

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2017

Building fails, please review the latest results

@yennster
Copy link
Contributor Author

yennster commented Dec 1, 2017

Fixed with help from @theotherjimmy
@0xc0170

@jeromecoutant
Copy link
Collaborator

Quick tests with the last version:

  • OK in mbed-os environment
  • OK in ci-shield environment

Thx Jenny

@jeromecoutant
Copy link
Collaborator

Minor question about the TODO comment https://github.com/yennster/mbed-os/blob/b3ba9a55b900058c3317f707bc867c91ff70fb84/tools/test.py#L141

Is this patch correcting it ?

@theotherjimmy
Copy link
Contributor

@jeromecoutant This patch does not touch that code or remove that comment. No, it does not correct that TODO.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 8, 2017

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 8, 2017

@theotherjimmy Are you happy with this patch?

@theotherjimmy
Copy link
Contributor

@0xc0170 The last commit is mine :P

@yennster
Copy link
Contributor Author

yennster commented Dec 8, 2017

@sarahmarshy

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2017

/morph build

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2017

Build : SUCCESS

Build number : 674
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5559/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2017

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2017

@theotherjimmy
Copy link
Contributor

@kegilbert That export failure is not showing any failed exports. Could you take a look?

@kegilbert
Copy link
Contributor

@theotherjimmy Looks like a node went down midrun on one of the boards, rekicking off.
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2017

Exporter Build : SUCCESS

Build number : 324
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5559/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test compilation issue for LWIP targets
7 participants