-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for default test config file #5559
Conversation
@sarahmarshy @geky related to #5543 |
@jeromecoutant Does this fix the issue you reported? |
/morph build |
Build : FAILUREBuild number : 579 |
Hi |
Building fails, please review the latest results |
3cf306d
to
d438324
Compare
Fixed with help from @theotherjimmy |
Quick tests with the last version:
Thx Jenny |
Minor question about the TODO comment https://github.com/yennster/mbed-os/blob/b3ba9a55b900058c3317f707bc867c91ff70fb84/tools/test.py#L141 Is this patch correcting it ? |
@jeromecoutant This patch does not touch that code or remove that comment. No, it does not correct that TODO. |
/morph build |
@theotherjimmy Are you happy with this patch? |
@0xc0170 The last commit is mine :P |
/morph build |
Build : SUCCESSBuild number : 674 Triggering tests/morph test |
Test : SUCCESSBuild number : 500 |
Exporter Build : FAILUREBuild number : 318 |
@kegilbert That export failure is not showing any failed exports. Could you take a look? |
@theotherjimmy Looks like a node went down midrun on one of the boards, rekicking off. |
Exporter Build : SUCCESSBuild number : 324 |
Description
Fixes #5543
This change allows for
mbed test
to build with anmbed_app.json
file by default if one exists in the project's root directory (i.e. for running the ci-test-shield tests). However, if thembed_app.json
file is not in the root directory, then it's location needs to be specified in the command with the--app-config
parameter.Steps to test or reproduce
Before fix:
If you run the ci-test-shield tests with
mbed test -t GCC_ARM -m NUCLEO_F207ZG -n tests* --compile
without a specified--app-config
you get the following errors related to the unspecifiedmbed_app.json
:After fix:
If you run the ci-test-shield tests with
mbed test -t GCC_ARM -m NUCLEO_F207ZG -n tests* --compile
without a specified--app-config
, if there exists anmbed_app.json
in the root directory of the project then the tests compile and run successfully.