New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit to fix the Online compiler issue for ARM mbed-os on REALTEK_RT… #5794

Merged
merged 2 commits into from Jan 8, 2018

Conversation

Projects
None yet
6 participants
@prashantrar
Contributor

prashantrar commented Jan 5, 2018

Notes:
Notes:
This pull request fixes the mbed online compile failure for the REALTEK_RTL8195AM device.

Description

The failure was caused due to a difference in the naming convention of object files generated by the online vs offline compiler.

The .sct file of the ARM compiler was modified to allow for seamless binary generation in both the online as well as offline compilers.

This PR is to fix the issue ARMmbed/mbed-os-example-blinky#102 and #5626

Status

READY

Migrations

Once this PR is merged, the online compilation should succeed

Related PRs

#5719 , The previous PR was closed by me due to some issue with the branch due to which I created a fresh fork, rebased with mbed-os master and submitting this new PR again

Outline the steps to test or reproduce the PR here.

Testing can be done with the following steps.

  1. Merge PR with master.
  2. Run the online compiler for any example for the REALTEK_RTL8195AM target
@prashantrar

This comment has been minimized.

Contributor

prashantrar commented Jan 5, 2018

@samchuarm, @0xc0170 @adbridge @theotherjimmy this is the new PR for the mbed os online compiler issue.

@adbridge adbridge requested a review from theotherjimmy Jan 5, 2018

@theotherjimmy

I think you need to modify line 21 as well.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 8, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 8, 2018

Build : SUCCESS

Build number : 813
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5794/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 8, 2018

Pipe closed, java exception

/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@theotherjimmy theotherjimmy merged commit a5f1426 into ARMmbed:master Jan 8, 2018

18 checks passed

AWS-CI uVisor Build & Test Verification build successful.
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@prashantrar prashantrar deleted the prashantrar:realtek-pr-online-compile branch Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment