Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit to fix the Online compiler issue for ARM mbed-os on REALTEK_RT… #5794

Merged
merged 2 commits into from
Jan 8, 2018

Conversation

prashantrar
Copy link
Contributor

Notes:
Notes:
This pull request fixes the mbed online compile failure for the REALTEK_RTL8195AM device.

Description

The failure was caused due to a difference in the naming convention of object files generated by the online vs offline compiler.

The .sct file of the ARM compiler was modified to allow for seamless binary generation in both the online as well as offline compilers.

This PR is to fix the issue ARMmbed/mbed-os-example-blinky#102 and #5626

Status

READY

Migrations

Once this PR is merged, the online compilation should succeed

Related PRs

#5719 , The previous PR was closed by me due to some issue with the branch due to which I created a fresh fork, rebased with mbed-os master and submitting this new PR again

Outline the steps to test or reproduce the PR here.

Testing can be done with the following steps.

  1. Merge PR with master.
  2. Run the online compiler for any example for the REALTEK_RTL8195AM target

@prashantrar
Copy link
Contributor Author

@samchuarm, @0xc0170 @adbridge @theotherjimmy this is the new PR for the mbed os online compiler issue.

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to modify line 21 as well.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 8, 2018

Build : SUCCESS

Build number : 813
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5794/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 8, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 8, 2018

Pipe closed, java exception

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 8, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 8, 2018

@theotherjimmy theotherjimmy merged commit a5f1426 into ARMmbed:master Jan 8, 2018
@prashantrar prashantrar deleted the realtek-pr-online-compile branch January 17, 2018 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants