New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread commissioning fix #5836

Merged
merged 2 commits into from Jan 19, 2018

Conversation

Projects
None yet
8 participants
@artokin
Contributor

artokin commented Jan 12, 2018

Description

Fix issue ARMmbed/coap-service#88.

Status

READY

Steps to test or reproduce

Device commissioning in Thread network was broken. With this fix the commissioning is working like described in: https://os.mbed.com/docs/v5.7/tutorials/mesh.html#thread-commissioning

artokin added some commits Jan 12, 2018

Squashed 'features/nanostack/FEATURE_NANOSTACK/coap-service/' changes…
… from d0a2597..8689fca

8689fca Reverting address check from transaction find (#89)
ca3c3ab Fix transactions to handle all token lengths (#87)

git-subtree-dir: features/nanostack/FEATURE_NANOSTACK/coap-service
git-subtree-split: 8689fca7b18e03776dce7083a03bd570a8bc0d43
Merge commit '47341478379429c08c468093e0326b5c79ecbc62'
* commit '47341478379429c08c468093e0326b5c79ecbc62':
  Squashed 'features/nanostack/FEATURE_NANOSTACK/coap-service/' changes from d0a2597..8689fca
@artokin

This comment has been minimized.

Contributor

artokin commented Jan 12, 2018

@adbridge , @0xc0170 would you please include this PR to the next patch release.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 12, 2018

/morph build

@0xc0170 0xc0170 added the needs: CI label Jan 12, 2018

@terhei terhei requested review from SeppoTakalo, terhei and mikter Jan 12, 2018

@adbridge

This comment has been minimized.

Contributor

adbridge commented Jan 12, 2018

@artokin The deadline for 5.7.3 has passed so we will get this into 5.7.4 in 2 weeks time.

@mbed-ci

This comment has been minimized.

mbed-ci commented Jan 12, 2018

Build : SUCCESS

Build number : 852
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5836/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jan 15, 2018

/morph uvisor-test

@0xc0170 0xc0170 added needs: review and removed needs: CI labels Jan 15, 2018

@terhei

terhei approved these changes Jan 17, 2018

@mikter

mikter approved these changes Jan 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jan 18, 2018

@artokin, is this PR still needed, considering the original issue has already been resolved?

@artokin

This comment has been minimized.

Contributor

artokin commented Jan 19, 2018

@cmonr , yes this fix is still needed. This will bring coap-service fix to Mbed-OS.

@cmonr cmonr merged commit f4aba25 into ARMmbed:master Jan 19, 2018

19 checks passed

ARM mbed CI Verification build successful.
Details
AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Local littlefs testing has passed
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment