-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXP LPC4088: Add missing SPI SSEL pin to Pinmap #5918
Conversation
The Pin P5_3 (p31) was missing from the NXP LPC4088 SPI PinMap for SSEL. Adding this Pin allows usage of SPISlave with SSP2 using the SSEL pin. The pin and its SSP2_SSEL function is both documented in https://os.mbed.com/media/uploads/embeddedartists/lpc4088_qsb_pinning.xlsx as well as in UM10562 LPC408x/407x User manual Rev. 3 — 12 March 2014 chapter 7.4.1.4 Table 90 (https://www.nxp.com/docs/en/user-guide/UM10562.pdf).
Automatic CI verification build not done, please verify manually. |
Hello, even though this is simple change, can you sign https://os.mbed.com/contributor_agreement/ ? (I could not locate your nick on mbed) ? |
Sure. Since I did not yet have a individual account, I just created a new one at https://os.mbed.com/users/scamille/ . |
/morph build |
Build : SUCCESSBuild number : 937 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 625 |
/morph build |
Build : SUCCESSBuild number : 948 Triggering tests/morph test |
Failure with unrelated device. Retesting. |
Test : SUCCESSBuild number : 779 |
Exporter Build : SUCCESSBuild number : 636 |
/morph uvisor-test |
The Pin P5_3 (p31) was missing from the NXP LPC4088 SPI PinMap for SSEL.
Adding this Pin allows usage of SPISlave with SSP2 using the SSEL pin.
The pin and its SSP2_SSEL function is both documented in https://os.mbed.com/media/uploads/embeddedartists/lpc4088_qsb_pinning.xlsx as well as in UM10562 LPC408x/407x User manual Rev. 3 — 12 March 2014 chapter 7.4.1.4 Table 90 (https://www.nxp.com/docs/en/user-guide/UM10562.pdf).
Notes:
Description
A few sentences describing the overall goals of the pull request's commits.
Status
READY/IN DEVELOPMENT/HOLD
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
YES | NO
Related PRs
List related PRs against other branches:
Todos
Deploy notes
Notes regarding the deployment of this PR. These should note any required changes in the build environment, tools, compilers and so on.
Steps to test or reproduce
Outline the steps to test or reproduce the PR here.