Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXP LPC4088: Add missing SPI SSEL pin to Pinmap #5918

Merged
merged 1 commit into from
Jan 26, 2018
Merged

NXP LPC4088: Add missing SPI SSEL pin to Pinmap #5918

merged 1 commit into from
Jan 26, 2018

Conversation

scamille
Copy link
Contributor

The Pin P5_3 (p31) was missing from the NXP LPC4088 SPI PinMap for SSEL.

Adding this Pin allows usage of SPISlave with SSP2 using the SSEL pin.

The pin and its SSP2_SSEL function is both documented in https://os.mbed.com/media/uploads/embeddedartists/lpc4088_qsb_pinning.xlsx as well as in UM10562 LPC408x/407x User manual Rev. 3 — 12 March 2014 chapter 7.4.1.4 Table 90 (https://www.nxp.com/docs/en/user-guide/UM10562.pdf).

Notes:

  • Pull requests will not be accepted until the submitter has agreed to the contributer agreement.
  • This is just a template, so feel free to use/remove the unnecessary things

Description

A few sentences describing the overall goals of the pull request's commits.

Status

READY/IN DEVELOPMENT/HOLD

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

YES | NO

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Todos

  • Tests
  • Documentation

Deploy notes

Notes regarding the deployment of this PR. These should note any required changes in the build environment, tools, compilers and so on.

Steps to test or reproduce

Outline the steps to test or reproduce the PR here.

The Pin P5_3 (p31) was missing from the NXP LPC4088 SPI PinMap for SSEL.

Adding this Pin allows usage of SPISlave with SSP2 using the SSEL pin.

The pin and its SSP2_SSEL function is both documented in https://os.mbed.com/media/uploads/embeddedartists/lpc4088_qsb_pinning.xlsx as well as in UM10562 LPC408x/407x User manual Rev. 3 — 12 March 2014 chapter 7.4.1.4 Table 90 (https://www.nxp.com/docs/en/user-guide/UM10562.pdf).
@mbed-ci
Copy link

mbed-ci commented Jan 24, 2018

Automatic CI verification build not done, please verify manually.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 24, 2018

Hello,

even though this is simple change, can you sign https://os.mbed.com/contributor_agreement/ ? (I could not locate your nick on mbed) ?

@scamille
Copy link
Contributor Author

Sure. Since I did not yet have a individual account, I just created a new one at https://os.mbed.com/users/scamille/ .

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 24, 2018

Build : SUCCESS

Build number : 937
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5918/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jan 24, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 25, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jan 25, 2018

Build : SUCCESS

Build number : 948
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5918/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Jan 25, 2018

Failure with unrelated device. Retesting.
/morph uvisor-test

@mbed-ci
Copy link

mbed-ci commented Jan 25, 2018

@mbed-ci
Copy link

mbed-ci commented Jan 25, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 26, 2018

/morph uvisor-test

@cmonr cmonr merged commit 124fbf4 into ARMmbed:master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants