NRF5x: Fix error_t conflict with gcc std>=gnu++11

[andrewleech]

Description

The Nordic implementation of FEATURE_BLE includes a typedef error_h which conflicts with a gcc standard implementation of error_h when compiled by GCC with newer standards enabled -std=gnu++11 or above.

The conflict is traced to nRF5XPalGattClient.cpp importing <memory.h>
This file does not actually need anything from this include however, it only requires <new.h> (for some compilers).

See #5979 for original fix and detailed discussion

Status

READY

Migrations

There should be no changes to end user code.

Related PRs

#5979

[mbed-ci]

--none--

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 1154
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6115/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Test : SUCCESS

Build number : 959
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6115/959

[mbed-ci]

Exporter Build : SUCCESS

Build number : 828
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6115/

[pan-]

Thanks for the fix; LGTM.

[brooksprumo]

Hi all, sorry in advance if this is the wrong place to post; let me know if/where this should be moved to instead.

I'm running into this same issue in Mbed 5.15.1, if I update the build profile to use C++17. With the default, C++14, everything compiles correctly.

I'm using an NRF52840 devkit and the Nordic BLE Softdevice too. Here's a snippet of the error. Let me know if there's more info anyone would like.

/home/me/gcc-arm-none-eabi-9-2019-q4-major/arm-none-eabi/include/errno.h:5:13: error: conflicting declaration 'typedef int error_t'
    5 | typedef int error_t;
      |             ^~~~~~~
In file included from ./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_SOFTDEVICE/TARGET_NRF52/source/common/common.h:68,
                 from ./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_SOFTDEVICE/TARGET_NRF52/source/btle/btle.cpp:17:
./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_SOFTDEVICE/TARGET_NRF52/source/common/ble_error.h:143:2: note: previous declaration as 'typedef enum error_t error_t'
  143 | }error_t;
      |  ^~~~~~~
In file included from ./mbed-os/features/FEATURE_BLE/ble/GattClient.h:22,
                 from ./mbed-os/features/FEATURE_BLE/ble/BLE.h:25,
                 from ./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_SOFTDEVICE/TARGET_NRF52/source/nRF5xn.h:20,
                 from ./mbed-os/features/FEATURE_BLE/targets/TARGET_NORDIC/TARGET_NORDIC_SOFTDEVICE/TARGET_NRF52/source/btle/btle.cpp:28: