-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NRF5x: Fix error_t
conflict with gcc std>=gnu++11
#6115
NRF5x: Fix error_t
conflict with gcc std>=gnu++11
#6115
Conversation
…t` whien compiling with gcc "-std=gnu++11" or above
--none-- |
/morph build |
Build : SUCCESSBuild number : 1154 Triggering tests/morph test |
Test : SUCCESSBuild number : 959 |
Exporter Build : SUCCESSBuild number : 828 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix; LGTM.
Hi all, sorry in advance if this is the wrong place to post; let me know if/where this should be moved to instead. I'm running into this same issue in Mbed 5.15.1, if I update the build profile to use C++17. With the default, C++14, everything compiles correctly. I'm using an NRF52840 devkit and the Nordic BLE Softdevice too. Here's a snippet of the error. Let me know if there's more info anyone would like.
|
Description
The Nordic implementation of FEATURE_BLE includes a typedef
error_h
which conflicts with a gcc standard implementation oferror_h
when compiled by GCC with newer standards enabled-std=gnu++11
or above.The conflict is traced to
nRF5XPalGattClient.cpp
importing<memory.h>
This file does not actually need anything from this include however, it only requires
<new.h>
(for some compilers).See #5979 for original fix and detailed discussion
Status
READY
Migrations
There should be no changes to end user code.
Related PRs
#5979