Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull request: add required info #6231

Merged
merged 1 commit into from Mar 1, 2018
Merged

pull request: add required info #6231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 15 additions & 5 deletions .github/pull_request_template.md
View file
Open in desktop
@@ -1,11 +1,21 @@
# Description
### Description

> Detailed changes summary | testing | dependencies
> Good example: https://os.mbed.com/docs/latest/reference/guidelines.html#workflow (Pull request template)
<!--
Required
Add here detailed changes summary, testing results, dependencies
Good example: https://os.mbed.com/docs/latest/reference/guidelines.html#workflow (Pull request template)
-->

# Pull request type

### Pull request type

<!--
Required
Please tick one of the following types
Copy link
Contributor

@cmonr cmonr Feb 27, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the additions of New target and Breaking change should this read "Please tick only one of the following" or "Please tick at least one of the following"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geky @adbridge ^^^

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only sounds fine. It should be one of these , not multiple selection here (if it is, PR should be split, doing multiple jobs).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the wording there is fine, please tick one , means just tick one :)

-->

- [ ] Fix
- [ ] Refactor
- [ ] New Target
- [ ] New target
- [ ] Feature
- [ ] Breaking change