Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mcu_lpc546xx: move "release_versions" to children and fix clock #6235

Merged
merged 2 commits into from
Mar 7, 2018
Merged

mcu_lpc546xx: move "release_versions" to children and fix clock #6235

merged 2 commits into from
Mar 7, 2018

Conversation

gorazdko
Copy link
Contributor

@gorazdko gorazdko commented Feb 28, 2018 •
edited
Loading

Abstract

  • mcu_lpc546xx: move "release_versions" to children
  • fix clock in lpc546xx related boards. Namely the wait() function took longer when adc was enabled

related issues: #5887
cc: @mmahadevan108

@gorazdko gorazdko changed the title mcu_lpc546xx: move "release_versions" to children nad fix clock mcu_lpc546xx: move "release_versions" to children and fix clock Feb 28, 2018
@mmahadevan108
Copy link
Contributor

Thank you. Looks good to me.

@cmonr
Copy link
Contributor

cmonr commented Feb 28, 2018

/morph build

1 similar comment
@cmonr
Copy link
Contributor

cmonr commented Mar 1, 2018

/morph build

@cmonr cmonr added the needs: CI label Mar 1, 2018
@cmonr
Copy link
Contributor

cmonr commented Mar 5, 2018

/morph build

1 similar comment
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 5, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

Build : SUCCESS

Build number : 1338
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6235/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

Exporter Build : SUCCESS

Build number : 994
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6235/

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

Test : SUCCESS

Build number : 1121
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6235/1121

@studavekar
Copy link
Contributor

/morph mbed2-build

@cmonr cmonr merged commit fb0eba4 into ARMmbed:master Mar 7, 2018
@maclobdell
Copy link
Contributor

great to see this patch came in. @mmahadevan108 - looks like this was the cause of at least one of the CI test shield failures we are looking into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

Assignees
No one assigned
Labels
release-version: 5.7.7 release-version: 5.8.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gorazdko @mmahadevan108 @cmonr @0xc0170 @mbed-ci @studavekar @maclobdell