Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRF52: Customize STDIO pins from config system #6275

Merged
merged 1 commit into from
Mar 6, 2018
Merged

NRF52: Customize STDIO pins from config system #6275

merged 1 commit into from
Mar 6, 2018

Conversation

marcuschangarm
Copy link
Contributor

This change makes it possible to customize the STDIO pins, which is needed by the Client Lite.

@cmonr cmonr requested a review from pan- March 5, 2018 19:22
@cmonr
Copy link
Contributor

cmonr commented Mar 5, 2018

/morph build

@cmonr cmonr added the needs: CI label Mar 5, 2018
@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

Build : SUCCESS

Build number : 1343
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6275/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 5, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 6, 2018

@yogpan01
Copy link
Contributor

yogpan01 commented Mar 7, 2018

@0xc0170 @adbridge Can we please get this PR in mbedOS-5.8-rc2 release ? We need this ASAP for us to start testing client on nRF52

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 7, 2018

@0xc0170 @adbridge Can we please get this PR in mbedOS-5.8-rc2 release ? We need this ASAP for us to start testing client on nRF52

It's not clear how this relates to rc2. It is a bugfix but from description in this PR, looks unrelated to our current ongoing release.

@adbridge
Copy link
Contributor

adbridge commented Mar 7, 2018

@yogpan01 Normally this would not be allowed to go into RC2 as it was not found during our OOB for RC1. Introducing new code between release candidates is a bad thing to do and could require a whole lot of testing to be repeated. In this particular case as the likely impact on anything else is very low risk, we will take it. But please be aware that this will not always be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants