Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATCmdParser]: Align process_oob() to vrecv()'s newline handling #6303

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

betzw
Copy link
Contributor

@betzw betzw commented Mar 8, 2018

Description

The newline handling between methods ATCmdParser::process_oob() and ATCmdParser::vrecv() is not aligned among those in the sense that in ATCmdParser::process_oob():

  • the newline characters '\n' and '\r' are not handled in a unified way
  • the _output_delimiter is used to detect the end-of incoming messages, which is not correct for every kind of AT commands based modules (instead a kind of input delimiter would be required) and as a consequnce
  • method ATCmdParser::process_oob() might fail to correctly recognize oobs under certain runtime conditions

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

@AnttiKauppila
Copy link

@jarvte Please review and approve

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 9, 2018

Build : SUCCESS

Build number : 1395
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6303/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 9, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 9, 2018

@cmonr cmonr merged commit cd9c28b into ARMmbed:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants