New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ATCmdParser]: Align `process_oob()` to `vrecv()`'s newline handling #6303

Merged
merged 1 commit into from Mar 15, 2018

Conversation

Projects
None yet
6 participants
@betzw
Contributor

betzw commented Mar 8, 2018

Description

The newline handling between methods ATCmdParser::process_oob() and ATCmdParser::vrecv() is not aligned among those in the sense that in ATCmdParser::process_oob():

  • the newline characters '\n' and '\r' are not handled in a unified way
  • the _output_delimiter is used to detect the end-of incoming messages, which is not correct for every kind of AT commands based modules (instead a kind of input delimiter would be required) and as a consequnce
  • method ATCmdParser::process_oob() might fail to correctly recognize oobs under certain runtime conditions

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

@0xc0170 0xc0170 requested review from hasnainvirk and AnttiKauppila Mar 8, 2018

@AnttiKauppila

This comment has been minimized.

Contributor

AnttiKauppila commented Mar 9, 2018

@jarvte Please review and approve

@jarvte

jarvte approved these changes Mar 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 9, 2018

/morph build

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 9, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Mar 9, 2018

Build : SUCCESS

Build number : 1395
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6303/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

0xc0170 approved these changes Mar 9, 2018

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 9, 2018

@cmonr cmonr merged commit cd9c28b into ARMmbed:master Mar 15, 2018

19 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Local events testing has passed
Details
travis-ci/littlefs Passed, code size is 10060B (+0.00%)
Details
travis-ci/mbed2-ATMEL Local mbed2-ATMEL testing has passed
Details
travis-ci/mbed2-MAXIM Local mbed2-MAXIM testing has passed
Details
travis-ci/mbed2-NORDIC Local mbed2-NORDIC testing has passed
Details
travis-ci/mbed2-NUVOTON Local mbed2-NUVOTON testing has passed
Details
travis-ci/mbed2-NXP Local mbed2-NXP testing has passed
Details
travis-ci/mbed2-RENESAS Local mbed2-RENESAS testing has passed
Details
travis-ci/mbed2-SILICON_LABS Local mbed2-SILICON_LABS testing has passed
Details
travis-ci/mbed2-STM Local mbed2-STM testing has passed
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment