Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatfs: Revert "Update error code mapping" #6323

Merged
merged 1 commit into from
Mar 12, 2018

Conversation

geky
Copy link
Contributor

@geky geky commented Mar 9, 2018

Description

Reverts #6120

This pr was a part of work spanning 5.7-5.9. There is not an immediate urgency for it to land on 5.8. During the review process of the 5.8 release it was noted that this change may cause problems for users that are relying on the existing (but broken) error codes.

To minimize noise, the plan is to revert the error code changes until 5.9, where it can land along with proper testing and documentation from related filesystem work.

I'll recreate #6120 targeting 5.9 if this revert makes it into 5.8.

cc @kegilbert, @deepikabhavnani, @adbridge, @sg-, @kjbracey-arm, @JanneKiiskila

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

@studavekar
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 9, 2018

Build : SUCCESS

Build number : 1407
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6323/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 10, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 10, 2018

@cmonr cmonr merged commit 190cd98 into ARMmbed:master Mar 12, 2018
@geky geky mentioned this pull request Mar 12, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants