Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #6252 #6346

Merged
merged 2 commits into from
Mar 16, 2018
Merged

Fix for #6252 #6346

merged 2 commits into from
Mar 16, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Mar 13, 2018

Description

This fixes #6252 . 2 fixes here:

  • two ram region used for L486 based targets (linker already defined two regions, macro was not set)
  • the most important - use hex for Wise 1570 target

cc @ARMmbed/team-st-mcd

@kimlep01 @mirelachirica @kivaisan I do not have the board to test it, please can you?

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

Based on the changes for other targets, these 2 were left.
Fixes ARMmbed#6252. Use hex rather than binary - use the hex format validation.
@kimlep01
Copy link

I can help testing this PR.

@bcostm
Copy link
Contributor

bcostm commented Mar 13, 2018

Tested OK on NUCLEO_L486RG. Thanks for the fix.

@kimlep01
Copy link

Tested and it works now with MTB_ADV_WISE_1570 using IAR and GCC_ARM.

@cmonr
Copy link
Contributor

cmonr commented Mar 15, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

Build : SUCCESS

Build number : 1440
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6346/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 15, 2018

/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

@0xc0170
Copy link
Contributor Author

0xc0170 commented Mar 15, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 15, 2018

Silly Windows CI machines, thinking they were done for the day...

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 15, 2018

@cmonr
Copy link
Contributor

cmonr commented Mar 15, 2018

java.io.IOException: Cannot retrieve the node's root. Most probably it's offline

ಠ_ಠ

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Mar 16, 2018

@cmonr cmonr merged commit 02130a2 into ARMmbed:master Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to flash for MTB_ADV_WISE_1570 target
5 participants