Code::Blocks project file exporter #6481

tsailer · 2018-03-27T15:06:02Z

Description

Add an exporter for Code::Blocks project files. It outputs native Code::Blocks projects, i.e. not makefile projects. Furthermore, if the target is NCS36510, it adds the necessary post build steps to add the required fib block to the generated elf file.

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[ ] Feature
[ ] Breaking change

theotherjimmy

Please split all lines around 80 characters.

Further, this seems very NCS36510 specific. Could you submit the exporter and the NCS changes separately?

theotherjimmy · 2018-03-27T15:34:04Z

targets/TARGET_ONSEMI/TARGET_NCS36510/device/TOOLCHAIN_GCC_ARM/NCS36510.ld

+        KEEP(*(.trim))
+    } > TRIM
+
+    .isr_vector :


This change, and all other changis in this file, are not related to creating an exporter. Please submit them as another PR.

theotherjimmy · 2018-03-27T15:37:05Z

tools/export/codeblocks/__init__.py

+            if f.startswith('-O') or f.startswith('-g'):
+                debug_flags.append(f)
+                continue
+            comp_flags.append(f)


This line should be in an else branch. Please rewrite the prior 4 lines as:

if f.startswith('-O') or f.startswith('-g): debug_flags.append(f) else: comp_flags.append(f)

theotherjimmy · 2018-03-27T15:37:38Z

tools/export/codeblocks/__init__.py

+        debug_flags = []
+        next_is_include = False
+        for f in self.flags['c_flags'] + self.flags['cxx_flags'] + self.flags['common_flags']:
+            f=f.strip()


Please put spaces around the =.

theotherjimmy · 2018-03-27T15:40:33Z

tools/export/codeblocks/cbp.tmpl

+				{% if ncs36510addfib -%}
+				<ExtraCommands>
+					<Add after="arm-none-eabi-objcopy -O ihex -R .fib -R .trim bin/Debug/{{project_name}}.elf bin/Debug/{{project_name}}.hex" />
+					<Add after="mbed-os/tools/export/codeblocks/ncs36510addfib.py bin/Debug/{{project_name}}.hex bin/Debug/{{project_name}}.fib" />


This is not allowed: after export on the website, a project will not contain the tools.

Where would be the proper place for such a tool?

This is where things get tricky. You could export that python script so that it is in the root of the project, then you can rely on it's existence. You can rely on anything in resources, and anything you explicitly create, so if you explicitly create the file, you're good to go. I, and possibly future users, would appreciate an addition to the third party notes section explaining that you need Python to compile with Code::Blocks and NCS36510.

theotherjimmy · 2018-03-27T15:40:45Z

tools/export/codeblocks/cbp.tmpl

+				{% if ncs36510addfib -%}
+				<ExtraCommands>
+					<Add after="arm-none-eabi-objcopy -O ihex -R .fib -R .trim bin/Release/{{project_name}}.elf bin/Release/{{project_name}}.hex" />
+					<Add after="mbed-os/tools/export/codeblocks/ncs36510addfib.py bin/Release/{{project_name}}.hex bin/Release/{{project_name}}.fib" />


Ditto for this line.

theotherjimmy · 2018-03-27T15:43:01Z

tools/export/codeblocks/__init__.py

+        inc_dirs = [x for x in inc_dirs if x is not None and x != '' and x != '.' and not x.startswith('bin') and not x.startswith('obj')];
+
+        c_sources = [self.filter_dot(s) for s in self.resources.c_sources]
+        targ = TARGET_MAP[self.target]


You will not have any configuration variables overridden on this target, making configuration incorrect. Please use self.toolchain.target instead.

theotherjimmy

Looks great! Thanks.

theotherjimmy · 2018-03-29T15:14:38Z

/morph build

mbed-ci · 2018-03-29T15:58:29Z

Build : SUCCESS

Build number : 1626
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6481/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-03-29T17:13:16Z

Test : SUCCESS

Build number : 1411
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6481/1411

mbed-ci · 2018-03-29T18:31:52Z

Exporter Build : SUCCESS

Build number : 1256
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6481/

0xc0170 · 2018-04-03T07:59:37Z

/morph build

mbed-ci · 2018-04-03T08:40:26Z

Build : SUCCESS

Build number : 1641
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6481/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

0xc0170 · 2018-04-03T13:08:04Z

Similar problem with jenkins CI as reported here #6510 (comment), investigating

mbed-ci · 2018-04-03T13:14:58Z

Exporter Build : SUCCESS

Build number : 1273
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6481/

maclobdell · 2018-04-03T13:44:48Z

cc @ARMmbed/team-onsemi

mbed-ci · 2018-04-03T14:50:20Z

Test : SUCCESS

Build number : 1430
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6481/1430

cmonr · 2018-04-03T19:56:28Z

/morph mbed2-build

… to be accessible in the template directory

…gnore so mbed compile doesn't pick them up

…m getting confused

0xc0170 · 2018-04-06T10:25:44Z

@tsailer Is this completed? I noticed some new commits. Restarting the CI

/morph build

tsailer · 2018-04-06T10:56:30Z

@0xc0170 yes, the generic part of the exporter is finished now

mbed-ci · 2018-04-06T11:24:02Z

Build : SUCCESS

Build number : 1674
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6481/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-04-06T14:17:51Z

Exporter Build : FAILURE

Build number : 1307
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6481/

theotherjimmy · 2018-04-06T14:20:18Z

No failures on that exporter job...

mbed-ci · 2018-04-06T15:58:28Z

Test : SUCCESS

Build number : 1468
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6481/1468

0xc0170 · 2018-04-09T08:04:52Z

/morph export-build
/morph mbed2-build

mbed-ci · 2018-04-09T10:12:26Z

Exporter Build : SUCCESS

Build number : 1311
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6481/

theotherjimmy

Looks good. Thanks.

0xc0170 requested a review from theotherjimmy March 27, 2018 15:11

0xc0170 added the needs: review label Mar 27, 2018

theotherjimmy suggested changes Mar 27, 2018

View reviewed changes

theotherjimmy previously approved these changes Mar 27, 2018

View reviewed changes

theotherjimmy added needs: CI and removed needs: review labels Mar 29, 2018

tsailer dismissed theotherjimmy’s stale review via ffbc9ee April 2, 2018 15:48

tsailer force-pushed the exporter-codeblocks branch from 0962c2f to ffbc9ee Compare April 2, 2018 15:48

Thomas Sailer and others added 8 commits April 6, 2018 11:31

Code::Blocks project file exporter

ca86cbf

some modifications from review

f53154a

remove NCS36510 specific changes from this branch

209310c

copy ncs36510addfib.py into project root, because it cannot be relied…

8478ec2

… to be accessible in the template directory

skip -c, sort compiler options and file list

84fe7ed

exporter: properly export libraries

7b7d5fc

proper compile flags for Release target; add fib/trim files to .mbedi…

69d7c53

…gnore so mbed compile doesn't pick them up

generate .mbedignore files in bin and obj to prevent mbed compile fro…

696a7f5

…m getting confused

tsailer force-pushed the exporter-codeblocks branch from 5456369 to 696a7f5 Compare April 6, 2018 09:48

0xc0170 removed the needs: CI label Apr 9, 2018

theotherjimmy approved these changes Apr 9, 2018

View reviewed changes

theotherjimmy added the release-version: 5.8.3 label Apr 9, 2018

theotherjimmy merged commit 854e436 into ARMmbed:master Apr 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code::Blocks project file exporter #6481

Code::Blocks project file exporter #6481

tsailer commented Mar 27, 2018 •

edited by 0xc0170

Loading

theotherjimmy left a comment

theotherjimmy Mar 27, 2018

theotherjimmy Mar 27, 2018

theotherjimmy Mar 27, 2018

theotherjimmy Mar 27, 2018

tsailer Mar 27, 2018

theotherjimmy Mar 27, 2018

theotherjimmy Mar 27, 2018

theotherjimmy Mar 27, 2018

theotherjimmy left a comment

theotherjimmy commented Mar 29, 2018

mbed-ci commented Mar 29, 2018

mbed-ci commented Mar 29, 2018

mbed-ci commented Mar 29, 2018

0xc0170 commented Apr 3, 2018

mbed-ci commented Apr 3, 2018

0xc0170 commented Apr 3, 2018

mbed-ci commented Apr 3, 2018

maclobdell commented Apr 3, 2018

mbed-ci commented Apr 3, 2018

cmonr commented Apr 3, 2018

0xc0170 commented Apr 6, 2018

tsailer commented Apr 6, 2018

mbed-ci commented Apr 6, 2018

mbed-ci commented Apr 6, 2018

theotherjimmy commented Apr 6, 2018

mbed-ci commented Apr 6, 2018

0xc0170 commented Apr 9, 2018

mbed-ci commented Apr 9, 2018

theotherjimmy left a comment

Code::Blocks project file exporter #6481

Code::Blocks project file exporter #6481

Conversation

tsailer commented Mar 27, 2018 • edited by 0xc0170 Loading

Description

Pull request type

theotherjimmy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theotherjimmy left a comment

Choose a reason for hiding this comment

theotherjimmy commented Mar 29, 2018

mbed-ci commented Mar 29, 2018

Triggering tests

mbed-ci commented Mar 29, 2018

mbed-ci commented Mar 29, 2018

0xc0170 commented Apr 3, 2018

mbed-ci commented Apr 3, 2018

Triggering tests

0xc0170 commented Apr 3, 2018

mbed-ci commented Apr 3, 2018

maclobdell commented Apr 3, 2018

mbed-ci commented Apr 3, 2018

cmonr commented Apr 3, 2018

0xc0170 commented Apr 6, 2018

tsailer commented Apr 6, 2018

mbed-ci commented Apr 6, 2018

Triggering tests

mbed-ci commented Apr 6, 2018

theotherjimmy commented Apr 6, 2018

mbed-ci commented Apr 6, 2018

0xc0170 commented Apr 9, 2018

mbed-ci commented Apr 9, 2018

theotherjimmy left a comment

Choose a reason for hiding this comment

tsailer commented Mar 27, 2018 •

edited by 0xc0170

Loading