New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove MODULE_UBLOX_ODIN_W2 from targets.json #6505

Merged
merged 2 commits into from Apr 10, 2018

Conversation

Projects
None yet
5 participants
@netanelgonen
Contributor

netanelgonen commented Mar 29, 2018

Description

remove this target from json file as this is not a real target but a parent target

Pull request type

[ X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr

This comment has been minimized.

Contributor

cmonr commented Mar 29, 2018

@netanelgonen Would you mind squashing your commits into a single commit, since the change set is so small? Once that's done, we can start CI.

@cmonr cmonr added the needs: work label Mar 29, 2018

Netanel Gonen
remove MODULE_UBLOX_ODIN_W2 from targets.json
remove this target from json file as this is not a real target
 but a parent target

fix error removing the target

@netanelgonen netanelgonen force-pushed the netanelgonen:remove_target branch from b6b7e51 to d925a04 Mar 29, 2018

@netanelgonen

This comment has been minimized.

Contributor

netanelgonen commented Mar 29, 2018

@cmonr commits squashed

@0xc0170 0xc0170 requested a review from ashok-rao Apr 9, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 9, 2018

@ARMmbed/team-ublox @ashok-rao Can you review please?

@0xc0170 0xc0170 added needs: review and removed needs: work labels Apr 9, 2018

@ashok-rao

This comment has been minimized.

Contributor

ashok-rao commented Apr 9, 2018

Change LGTM.. might want to fix the alignment in the json though..

@@ -2052,6 +2052,7 @@
"device_has_remove": ["RTC", "SLEEP"],
"features": ["LWIP"],
"device_name": "STM32F439ZI",
"public": false,

This comment has been minimized.

@cmonr

cmonr Apr 9, 2018

Contributor

Please correct the indentation and replace tabs with spaces.

@netanelgonen

This comment has been minimized.

Contributor

netanelgonen commented Apr 9, 2018

@cmonr fixed. can you please check

@cmonr

cmonr approved these changes Apr 9, 2018

LGTM!

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 9, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 9, 2018

Build : SUCCESS

Build number : 1693
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6505/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit d9e5c4b into ARMmbed:master Apr 10, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8603 cycles (-437 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B (+0.00%)
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment