Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove MODULE_UBLOX_ODIN_W2 from targets.json #6505

Merged
merged 2 commits into from Apr 10, 2018
Merged

remove MODULE_UBLOX_ODIN_W2 from targets.json #6505

merged 2 commits into from Apr 10, 2018

Conversation

netanelgonen
Copy link
Contributor

@netanelgonen netanelgonen commented Mar 29, 2018 •
edited

Description

remove this target from json file as this is not a real target but a parent target

Pull request type

[ X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@netanelgonen netanelgonen mentioned this pull request Mar 29, 2018
Closed
@cmonr cmonr self-requested a review March 29, 2018 06:28
@cmonr
Copy link
Contributor

cmonr commented Mar 29, 2018

@netanelgonen Would you mind squashing your commits into a single commit, since the change set is so small? Once that's done, we can start CI.

cmonr
cmonr previously approved these changes Mar 29, 2018
View reviewed changes
remove MODULE_UBLOX_ODIN_W2 from targets.json
d925a04 
remove this target from json file as this is not a real target
 but a parent target

fix error removing the target
@netanelgonen
Copy link
Contributor Author

@cmonr commits squashed

@0xc0170 0xc0170 requested a review from ashok-rao April 9, 2018 15:17
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 9, 2018

@ARMmbed/team-ublox @ashok-rao Can you review please?

@ashok-rao
Copy link
Contributor

Change LGTM.. might want to fix the alignment in the json though..

cmonr
cmonr suggested changes Apr 9, 2018
View reviewed changes
targets/targets.json Outdated
@@ -2052,6 +2052,7 @@
"device_has_remove": ["RTC", "SLEEP"],
"features": ["LWIP"],
"device_name": "STM32F439ZI",
"public": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the indentation and replace tabs with spaces.

@netanelgonen
Copy link
Contributor Author

@cmonr fixed. can you please check

cmonr
cmonr approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 9, 2018

Build : SUCCESS

Build number : 1693
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6505/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

Exporter Build : SUCCESS

Build number : 1325
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6505/

@mbed-ci
Copy link

mbed-ci commented Apr 10, 2018

Test : SUCCESS

Build number : 1487
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6505/1487

@cmonr cmonr merged commit d9e5c4b into ARMmbed:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@ashok-rao ashok-rao Awaiting requested review from ashok-rao

Assignees
No one assigned
Labels
release-version: 5.8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@netanelgonen @cmonr @0xc0170 @ashok-rao @mbed-ci