New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup get_config (mbed compile --config) #6580

Merged
merged 6 commits into from Apr 17, 2018

Conversation

Projects
None yet
5 participants
@theotherjimmy
Contributor

theotherjimmy commented Apr 9, 2018

Description

I made get_config a little nicer to read, and the output a little nicer
to read.
before


Macros
------
Defined with "macros": [u'UNITY_INCLUDE_CONFIG_H']
Generated from configuration parameters: [u'MBED_CONF_LORA_DEVICE_ADDRESS=0x00000000', u'MBED_CONF_CELLULAR_USE_APN_LOOKUP=1', u'MBED_CONF_LORA_DEVICE_EUI={0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}', u'MBED_CONF_LWIP_IPV4_ENABLED=1', u'MBED_CONF_LWIP_DEFAULT_THREAD_STACKSIZE=512', u'MBED_CONF_LWIP_IP_VER_PREF=4', u'MBED_CONF_EVENTS_PRESENT=1', u'NSAPI_PPP_IPV4_AVAILABLE=1', u'MBED_CONF_PLATFORM_FORCE_NON_COPYABLE_ERROR=0', u'MBED_CONF_DRIVERS_UART_SERIAL_RXBUF_SIZE=256', u'NVSTORE_MAX_KEYS=16', u'MBED_CONF_LWIP_ADDR_TIMEOUT=5', u'CFSTORE_STORAGE_DISABLE=0', u'MBED_LFS_BLOCK_SIZE=512', u'MBED_CONF_PLATFORM_STDIO_BUFFERED_SERIAL=0', u'MBED_CONF_LORA_NWKSKEY={0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}', u'MBED_CONF_LORA_DUTY_CYCLE_ON=1', u'MBED_CONF_LWIP_TCP_SERVER_MAX=4', u'MBED_LFS_READ_SIZE=64', u'MBED_CONF_LORA_TX_MAX_SIZE=64', u'MBED_CONF_LORA_APPSKEY={0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}', u'MBED_CONF_LWIP_TCP_ENABLED=1', u'MBED_CONF_LORA_APP_PORT=15', u'MBED_CONF_PPP_CELL_IFACE_AT_PARSER_TIMEOUT=8000', u'MBED_CONF_EVENTS_SHARED_STACKSIZE=1024', u'MBED_CONF_LORA_APPLICATION_EUI={0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}', u'NSAPI_PPP_AVAILABLE=0', u'MBED_CONF_PPP_CELL_IFACE_APN_LOOKUP=1', u'MBED_LFS_LOOKAHEAD=512', u'MBED_CONF_LWIP_USE_MBED_TRACE=0', u'MBED_CONF_PLATFORM_STDIO_CONVERT_NEWLINES=0', u'MBED_CONF_LORA_OVER_THE_AIR_ACTIVATION=1', u'MBED_CONF_LORA_ADR_ON=1', u'MBED_CONF_LWIP_ETHERNET_ENABLED=1', u'MBED_LFS_ENABLE_INFO=0', u'MBED_CONF_LORA_PUBLIC_NETWORK=1', u'MBED_CONF_LWIP_ENABLE_PPP_TRACE=0', u'MBED_CONF_EVENTS_SHARED_DISPATCH_FROM_APPLICATION=0', u'MBED_CONF_LWIP_UDP_SOCKET_MAX=4', u'MBED_CONF_LWIP_TCPIP_THREAD_STACKSIZE=1200', u'MBED_LFS_PROG_SIZE=64', u'MBED_CONF_LWIP_PPP_THREAD_STACKSIZE=768', u'MBED_CONF_LORA_PHY=0', u'NSAPI_PPP_IPV6_AVAILABLE=0', u'MBED_CONF_NSAPI_PRESENT=1', u'MBED_CONF_FILESYSTEM_PRESENT=1', u'MBED_CONF_PPP_CELL_IFACE_BAUD_RATE=115200', u'MBED_CONF_PPP_CELL_IFACE_AT_PARSER_BUFFER_SIZE=256', u'MBED_CONF_PLATFORM_STDIO_FLUSH_AT_EXIT=1', u'MBED_CONF_LORA_NB_TRIALS=12', u'MBED_CONF_PLATFORM_STDIO_BAUD_RATE=9600', u'MBED_CONF_LWIP_IPV6_ENABLED=0', u'MBED_LFS_INTRINSICS=1', u'MBED_CONF_EVENTS_SHARED_HIGHPRIO_STACKSIZE=1024', u'NVSTORE_ENABLED=1', u'MBED_CONF_LORA_LBT_ON=0', u'MBED_CONF_PLATFORM_DEFAULT_SERIAL_BAUD_RATE=9600', u'MBED_CONF_LWIP_TCP_SOCKET_MAX=4', u'MBED_CONF_EVENTS_SHARED_EVENTSIZE=256', u'MBED_CONF_LWIP_DEBUG_ENABLED=0', u'MBED_CONF_CELLULAR_RANDOM_MAX_START_DELAY=0', u'MBED_CONF_LWIP_SOCKET_MAX=4', u'MBED_CONF_DRIVERS_UART_SERIAL_TXBUF_SIZE=256', u'MBED_CONF_PLATFORM_STDIO_CONVERT_TTY_NEWLINES=0', u'MBED_CONF_EVENTS_USE_LOWPOWER_TIMER_TICKER=0', u'MBED_CONF_LORA_APPLICATION_KEY={0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}', u'MBED_CONF_LWIP_ADDR_TIMEOUT_MODE=1', u'MBED_CONF_RTOS_PRESENT=1', u'MBED_CONF_EVENTS_SHARED_HIGHPRIO_EVENTSIZE=256']

(Yes, it's all one line and contains config)

After


Macros
------
UNITY_INCLUDE_CONFIG_H

Each macro on a line, like the config section, and does not contain config because that's redundant.

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 9, 2018

I made get_config a little nicer to read, and the output a little nicer
to read.

Diff between how it was and it is now part of this PR?

@0xc0170 0xc0170 requested review from screamerbg and MarceloSalazar Apr 9, 2018

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Apr 9, 2018

@0xc0170 Yeah, just a sec. Updated.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 16, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Apr 16, 2018

Build : SUCCESS

Build number : 1756
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6580/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Apr 17, 2018

Still waiting on @MarceloSalazar and/or @screamerbg.

@cmonr

cmonr approved these changes Apr 17, 2018

LGTM

@cmonr cmonr merged commit 3afbfd6 into ARMmbed:master Apr 17, 2018

12 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9533 cycles (+259 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/littlefs Passed, code size is 10092B
Details
travis-ci/tools Local tools testing has passed
Details

@cmonr cmonr removed the ready for merge label Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment